Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unintended change to output dtype of match_histograms #6169

Merged
merged 1 commit into from
Jan 7, 2022
Merged

Fix unintended change to output dtype of match_histograms #6169

merged 1 commit into from
Jan 7, 2022

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Jan 7, 2022

Description

This fixes an unintentional change in output dtype for match_histograms. Specifically, for integer images, the output should not be cast to floating-point dtype.

closes #6168

Checklist

  • Docstrings for all functions
  • Gallery example in ./doc/examples (new features only)
  • Benchmark in ./benchmarks, if your changes aren't covered by an
    existing benchmark
  • Unit tests
  • Clean style in the spirit of PEP8
  • Descriptive commit messages (see below)

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@grlee77 grlee77 added 🩹 type: Bug fix Fixes unexpected or incorrect behavior backport: 0.19.x labels Jan 7, 2022
@grlee77 grlee77 added this to the 0.19.2 milestone Jan 7, 2022
@alexdesiqueira alexdesiqueira merged commit 98e1579 into scikit-image:main Jan 7, 2022
@alexdesiqueira
Copy link
Member

Thank you @grlee77!

@alexdesiqueira
Copy link
Member

@meeseeksdev backport to v0.19.x

meeseeksmachine pushed a commit to meeseeksmachine/scikit-image that referenced this pull request Jan 7, 2022
@grlee77 @meeseeksmachine
Backport PR scikit-image#6169: Fix unintended change to output dtype …
09b999a 
…of match_histograms
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 7, 2022
Merged
hmaarrfk added a commit that referenced this pull request Jan 7, 2022
@hmaarrfk
Merge pull request #6172 from meeseeksmachine/auto-backport-of-pr-616…
d90ce0b 
…9-on-v0.19.x

Backport PR #6169 on branch v0.19.x (Fix unintended change to output dtype of match_histograms)
@mkcor mkcor mentioned this pull request Jan 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmaarrfk hmaarrfk hmaarrfk left review comments

@mkcor mkcor mkcor approved these changes

Assignees
No one assigned
Labels
🩹 type: Bug fix Fixes unexpected or incorrect behavior
Projects
None yet
Milestone
0.19.2
Development

Successfully merging this pull request may close these issues.

broken match histograms gallery example
4 participants
@grlee77 @alexdesiqueira @hmaarrfk @mkcor