Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue6190 - inconsistent default parameters in pyramids.py #6191

Merged
merged 4 commits into from
Jan 19, 2022
Merged

Fix issue6190 - inconsistent default parameters in pyramids.py #6191

merged 4 commits into from
Jan 19, 2022

Conversation

hndgzkn
Copy link
Contributor

@hndgzkn hndgzkn commented Jan 19, 2022

Description

Fixes #6190

For backward compatibility keeps multichannel=False and sets channel_axis=None for pyramid_reduce, pyramid_gaussian and pyramid_laplacian.

Adds tests for each function to test the default values.

Removes unused import from scipy import ndimage as ndi.

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

grlee77
grlee77 approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@grlee77 grlee77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hndgzkn, this looks great!

Once this is merged we will backport it to the v0.19.x branch so it will be fixed for the upcoming 0.19.2 release

@grlee77 grlee77 added backport: 0.19.x 🩹 type: Bug fix Fixes unexpected or incorrect behavior labels Jan 19, 2022
@grlee77 grlee77 added this to the 0.19.2 milestone Jan 19, 2022
mkcor
mkcor approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@mkcor mkcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thank you so much, @hndgzkn.

@mkcor mkcor merged commit 10a102c into scikit-image:main Jan 19, 2022
@grlee77
Copy link
Contributor

grlee77 commented Jan 19, 2022

@meeseeksdev backport to v0.19.x

@meeseeksmachine meeseeksmachine mentioned this pull request Jan 19, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/scikit-image that referenced this pull request Jan 19, 2022
@hndgzkn @meeseeksmachine
Backport PR scikit-image#6191: Fix issue6190 - inconsistent default p…
6385add 
…arameters in pyramids.py
@hmaarrfk
Copy link
Member

Would it be appropriate to add the backport command back to the PR template? I always forget it.. copy pasting is so much easier.

@hndgzkn hndgzkn deleted the fix_issue6190 branch January 19, 2022 20:13
@grlee77
Copy link
Contributor

grlee77 commented Jan 19, 2022

Sure, that sounds good to me

grlee77 added a commit that referenced this pull request Jan 20, 2022
@grlee77
Merge pull request #6193 from meeseeksmachine/auto-backport-of-pr-619…
21db625 
…1-on-v0.19.x

Backport PR #6191 on branch v0.19.x (Fix issue6190 - inconsistent default parameters in pyramids.py)
@mkcor mkcor mentioned this pull request Jan 24, 2022
Closed
tibuch pushed a commit to fmi-faim/scikit-image that referenced this pull request Mar 14, 2022
@hndgzkn @tibuch
Fix inconsistent default parameters in pyramids.py (scikit-image#6191)
62fbb63 
* fix pyramid_reduce defaults
* fix pyramid_gaussian defaults
* fix pyramid_laplacian defaults
* remove unused import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkcor mkcor mkcor approved these changes

@grlee77 grlee77 grlee77 approved these changes

Assignees
No one assigned
Labels
🩹 type: Bug fix Fixes unexpected or incorrect behavior
Projects
None yet
Milestone
0.19.2
Development

Successfully merging this pull request may close these issues.

Inconsistent default parameters for pyramid_reduce
4 participants
@hndgzkn @grlee77 @hmaarrfk @mkcor