Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smoothed image computation when mask is None in canny #6348

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

rfezzani
Copy link
Member

Description

Fixes #6346

Checklist

  • Docstrings for all functions
  • Gallery example in ./doc/examples (new features only)
  • Benchmark in ./benchmarks, if your changes aren't covered by an
    existing benchmark
  • Unit tests
  • Clean style in the spirit of PEP8
  • Descriptive commit messages (see below)

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • There is a bot to help automate backporting a PR to an older branch. For
    example, to backport to v0.19.x after merging, add the following in a PR
    comment: @meeseeksdev backport to v0.19.x
  • To run benchmarks on a PR, add the run-benchmark label. To rerun, the label
    can be removed and then added again. The benchmark output can be checked in
    the "Actions" tab.

@rfezzani rfezzani added 🩹 type: Bug fix Fixes unexpected or incorrect behavior backport: 0.19.x labels Apr 20, 2022
@rfezzani
Copy link
Member Author

@stefanv, the bug #6346 you reported is due to a change in image preprocessing when no mask is provided. In this case the mask is all ones and the constant mode introduces artifacts in the border of the image as cval=0 by default.
Should we change default mode (as already proposed #4342 (comment)) in this PR or in another one?

Copy link
Contributor

@grlee77 grlee77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rfezzani. Let's do the change to canny's mode default in a separate PR.

@grlee77 grlee77 added this to the 0.19.3 milestone Apr 25, 2022
@grlee77 grlee77 merged commit 376d30f into scikit-image:main Apr 25, 2022
@grlee77
Copy link
Contributor

grlee77 commented Apr 25, 2022

@meeseeksdev backport to v0.19.x

meeseeksmachine pushed a commit to meeseeksmachine/scikit-image that referenced this pull request Apr 25, 2022
grlee77 pushed a commit that referenced this pull request Apr 26, 2022
…n canny (#6359)

Co-authored-by: Riadh Fezzani <rfezzani@gmail.com>
alexdesiqueira pushed a commit to alexdesiqueira/scikit-image that referenced this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🩹 type: Bug fix Fixes unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canny outputs border artifacts when image is constant with default parameters
2 participants