Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin to pip<22.1 #6379

Merged
merged 6 commits into from May 17, 2022
Merged

pin to pip<22.1 #6379

merged 6 commits into from May 17, 2022

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented May 12, 2022

Description

investigating MacOS CI failures observed on main in #5198. I see that v0.19.x has setuptools pinned to <= 59.4. trying that on here as well to see if that resolves the issue.

update: The issue seems related to the recent release of pip 22.1 and not setuptools.

Checklist

  • Docstrings for all functions
  • Gallery example in ./doc/examples (new features only)
  • Benchmark in ./benchmarks, if your changes aren't covered by an
    existing benchmark
  • Unit tests
  • Clean style in the spirit of PEP8
  • Descriptive commit messages (see below)

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • There is a bot to help automate backporting a PR to an older branch. For
    example, to backport to v0.19.x after merging, add the following in a PR
    comment: @meeseeksdev backport to v0.19.x
  • To run benchmarks on a PR, add the run-benchmark label. To rerun, the label
    can be removed and then added again. The benchmark output can be checked in
    the "Actions" tab.

@grlee77 grlee77 added the 🤖 type: Infrastructure CI, packaging, tools and automation label May 12, 2022
@grlee77 grlee77 changed the title try pinning setuptools in pyproject.toml pin setuptools in pyproject.toml May 12, 2022
@grlee77 grlee77 changed the title pin setuptools in pyproject.toml pin to pip<22.1 May 12, 2022
Copy link
Contributor

@jarrodmillman jarrodmillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to merge this soon to eliminate this failure on new PRs.

@jarrodmillman jarrodmillman mentioned this pull request May 16, 2022
@hmaarrfk
Copy link
Member

What is the source of the issue. Is there a reference to an upstream issue. Why. Can we expect our users to install the software if we can't with the latest version of pip?

@stefanv stefanv merged commit e013f60 into scikit-image:main May 17, 2022
alexdesiqueira pushed a commit to alexdesiqueira/scikit-image that referenced this pull request May 24, 2022
@jarrodmillman jarrodmillman added this to the 0.20 milestone Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 type: Infrastructure CI, packaging, tools and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants