Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forwardport gh-6369: Fix windows wheels: use vsdevcmd.bat to make sure rc.exe is on the path #6417

Merged
merged 1 commit into from Jun 16, 2022
Merged

forwardport gh-6369: Fix windows wheels: use vsdevcmd.bat to make sure rc.exe is on the path #6417

merged 1 commit into from Jun 16, 2022

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Jun 13, 2022

Description

This fixed was introduced for the v0.19.3 and should also be needed on main. The only difference from the changes in this PR vs. gh-6369 is that Python 3.7 is no longer included in the build matrix

Checklist

  • Docstrings for all functions
  • Gallery example in ./doc/examples (new features only)
  • Benchmark in ./benchmarks, if your changes aren't covered by an
    existing benchmark
  • Unit tests
  • Clean style in the spirit of PEP8
  • Descriptive commit messages (see below)

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • There is a bot to help automate backporting a PR to an older branch. For
    example, to backport to v0.19.x after merging, add the following in a PR
    comment: @meeseeksdev backport to v0.19.x
  • To run benchmarks on a PR, add the run-benchmark label. To rerun, the label
    can be removed and then added again. The benchmark output can be checked in
    the "Actions" tab.

@grlee77
use vsdevcmd.bat to make sure rc.exe is on the path
5671d22 
The script for this is based on
actions/runner-images#294 (comment)

but we additionally specify an -arch flag to make sure we get the expected architecture
@grlee77 grlee77 added 🔧 type: Maintenance Refactoring and maintenance of internals 🤖 type: Infrastructure CI, packaging, tools and automation labels Jun 13, 2022
@alexdesiqueira
Copy link
Member

Thank you @grlee77! Feel free to merge.

@alexdesiqueira alexdesiqueira merged commit 0c188ee into scikit-image:main Jun 16, 2022
@jarrodmillman jarrodmillman added this to the 0.20 milestone Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexdesiqueira alexdesiqueira alexdesiqueira approved these changes

Assignees
No one assigned
Labels
🤖 type: Infrastructure CI, packaging, tools and automation 🔧 type: Maintenance Refactoring and maintenance of internals
Projects
None yet
Milestone
0.20
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grlee77 @alexdesiqueira @jarrodmillman