Simplify sort-by-absolute-value in ridge filters. #6440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using np.take_along_axis is explicitly mentioned in the docstring of np.argsort, so let's use that rather than a hand-rolled version (which predates np.take_along_axis).
mkcor
approved these changes
Jul 15, 2022
jni
approved these changes
Jul 16, 2022
|
Thank you @anntzer! |
grlee77
added a commit
to grlee77/cucim
that referenced
this pull request
Oct 28, 2022
see: scikit-image/scikit-image#6149 scikit-image/scikit-image#6440 scikit-image/scikit-image#6446 scikit-image/scikit-image#6509 These fix various bugs, simplify the implementaiton and reduce the memory footprint
rapids-bot bot
pushed a commit
to rapidsai/cucim
that referenced
this pull request
Nov 16, 2022
…y footprint) (#423) related to #419 A large overhaul of the ridge filters, addressing inaccuracies and errors has been implemented for scikit-image 0.20. This PR ports the same changes to these functions to cuCIM. upstream PRs: - scikit-image/scikit-image#6149 - scikit-image/scikit-image#6440 - scikit-image/scikit-image#6446 - scikit-image/scikit-image#6509 These fix various bugs, simplify the implementation and reduce the memory footprint Authors: - Gregory Lee (https://github.com/grlee77) Approvers: - Gigon Bae (https://github.com/gigony) URL: #423
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using np.take_along_axis is explicitly mentioned in the docstring of
np.argsort, so let's use that rather than a hand-rolled version (which
predates np.take_along_axis).
Description
Checklist
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.example, to backport to v0.19.x after merging, add the following in a PR
comment:
@meeseeksdev backport to v0.19.xrun-benchmarklabel. To rerun, the labelcan be removed and then added again. The benchmark output can be checked in
the "Actions" tab.