Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update plot_euler_number.py for maplotlib 3.6 compatibility #6522

Merged
merged 1 commit into from Sep 16, 2022

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Sep 16, 2022

Description

closes #6521

As of matplotlib 3.6, passing kwargs to the figure gca method is no longer supported

Checklist

  • Docstrings for all functions
  • Gallery example in ./doc/examples (new features only)
  • Benchmark in ./benchmarks, if your changes aren't covered by an
    existing benchmark
  • Unit tests
  • Clean style in the spirit of PEP8
  • Descriptive commit messages (see below)

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • There is a bot to help automate backporting a PR to an older branch. For
    example, to backport to v0.19.x after merging, add the following in a PR
    comment: @meeseeksdev backport to v0.19.x
  • To run benchmarks on a PR, add the run-benchmark label. To rerun, the label
    can be removed and then added again. The benchmark output can be checked in
    the "Actions" tab.

passing kwargs to fig.gca() is no longer supported
@grlee77 grlee77 added the 🩹 type: Bug fix Fixes unexpected or incorrect behavior label Sep 16, 2022
@grlee77
Copy link
Contributor Author

grlee77 commented Sep 16, 2022

@scikit-image/core : please approve/merge so CI will be back to a working state

Copy link
Member

@rfezzani rfezzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rfezzani rfezzani merged commit 180e47a into scikit-image:main Sep 16, 2022
@grlee77
Copy link
Contributor Author

grlee77 commented Sep 16, 2022

Thanks @rfezzani!

@jarrodmillman jarrodmillman added this to the 0.20 milestone Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🩹 type: Bug fix Fixes unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

matplotlib 3.6.0 compatibility
3 participants