Inverse Radon transform: Expand functionality #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stefanv @emmanuelle Any chance of a review? |
skimage/transform/radon_transform.py
Outdated
| @@ -156,6 +160,10 @@ def iradon(radon_image, theta=None, output_size=None, | |||
| Assume the reconstructed image is zero outside the inscribed circle. | |||
| Also changes the default output_size to match the behaviour of | |||
| ``radon`` called with ``circle=True``. | |||
| projection_shifts : 1D array, dtype=float | |||
|
I put two comments. Is it possible to illustrate this option in the gallery? |
|
@sciunto Thanks for looking into this. About the gallery, I think we should be careful with including too many features in what is now intended to be an introductory example. The correct place for examples of the use of these features is in a longer, tutorial-like introduction to tomography in scikit-image, I think. And I don't want to write that yet, as the tomography part of scikit-image still feels somewhat incomplete. |
|
oki :) |
|
@stefanv Any suggestions for who I can ask for a review for this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
projection_shiftsargument toiradon, with identical functionality as foriradon_sartBoth changes are intended to be backwards compatible.
From my side, this is ready for merge.