Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a parameter for signed orientations in HOGs #715

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

angelatlarge
Copy link
Contributor

The original Dalal and Triggs paper discusses signed versus unsigned orientations. While for pedestrian detectors unsigned orientations seemed to be more robust, D&T discussed that for vehicle detection, signed orientations seemed to perform better. It seemed like it might be useful to offer this feature in scikit-image.

The change is implemented by pulling out the 180 angle maximum into a separate variable initialized based on the signed parameter to the _hog(...) function. The signed parameter defaults to false because a) it is more useful in most cases and b) to maintain compatibility with existing code. The one place where 180 immediate constant wasn't replace in _hog(...) code is the radian->degree conversion on line 104

@emmanuelle
Copy link
Member

This PR never received much attention, but would be easy to merge if the new feature is considered useful.

Base automatically changed from master to main February 18, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
HOG descriptor
Needs Work / In Progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants