Suppress error message during failed UmfpackContext import #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By putting the failing statement in a try: except: clause, the exception is caught and the error message is silenced. See https://groups.google.com/d/msg/scikit-image/FrM5IGP6wh4/1hp-FtVZmfcJ and http://stackoverflow.com/questions/13977970/ignore-exceptions-printed-to-stderr-in-del/13977992?noredirect=1#comment28386412_13977992
|
Do you mind adding a comment with a link to the discussion so that we will understand the code in the future and remember to clean it up? Thereafter, I think it's good to merge. |
|
Sure thing, @stefanv. Q: what do you think about the deprecation path for the default "mode" cascade in random_walker? Should I push the deprecation in this release, and add to-do for the next release? |
|
If deprecations are to be made, now is the time to do it. It makes sense to me. |
stefanv
added a commit
that referenced
this pull request
Oct 11, 2013
Suppress error message during failed UmfpackContext import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This message was caused by a bug in scipy that was fixed by @tonysyu after 0.12. Since we probably don't want to bump up the scipy requirement that high, this is probably a useful thing to do for scikit-image users.
See discussion in
https://groups.google.com/d/msg/scikit-image/FrM5IGP6wh4/1hp-FtVZmfcJ
and solution proposed in
http://stackoverflow.com/questions/13977970/ignore-exceptions-printed-to-stderr-in-del/13977992?noredirect=1#comment28386412_13977992
@JDWarner proposes that we use the priority pyamg -> umf -> brute force for random walker. I'll let others decide whether we want that in this release. But I think suppressing the error message at least is a very nice thing to include.