-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a javascript slideshow of images in skimage.data #993
base: main
Are you sure you want to change the base?
Conversation
The error seems to be unrelated. |
Hi @vighneshbirodkar, thanks a bunch for working on this! It looks great. Some comments:
Thanks again! |
Hello @stefanv
|
@stefanv |
This looks very nice. Two further suggestions:
|
@ahojnnes |
Automate. Look at http://scikit-image.org/docs/0.9.x/api/skimage.transform.html#hough-line |
You want the plot directive to be inserted automatically at the end of every docstring ? |
Yes, you are right. the image directive is better! |
So I will add some code to doc/conf.py to append at the end of every
|
If Sphinx uses Jinja anyway, then we're fine. With "example images" I meant images used in the gallery, instead of images from skimage.data. The theme should be pretty easy to tweak by hand--I can help with that if you're not familiar with CSS. |
Hello @stefanv |
@stefanv Can you tell me what changes I need to make to get captions at the bottom ? Or would you prefer merging this and making the changes on your own ? |
Thanks @vighneshbirodkar! I've put the data gallery in this PR here to make it easy for everyone to have a quick look. I'm not a huge fan of the current Javascript slideshow used ... it feels a bit clunky. The other thing that was mentioned in #989 was that it would be nice to be able to see the shape and dtype for each image from the API docs and if possible also in the data gallery. |
The shape and dtype can easily be extracted on doc build and included. We can look at something lightweight like: I don't really mind galleria, but the theme used on the front page is much |
To address #989
I am not used to HTML/javascript, so any HTML/javascript/CSS advice will be appreciated.
If everyone agrees with the approach, I will go ahead and document parts of my code.
The javascript slideshow Galleria was chosen because it was simple to use and allowed lazy loading of images.
I have put things as I see fit, but I won't be surprised if this seems totally crazy to others and is rejected.
@sharky93