Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the sidebar subtitle font slightly smaller #57

Closed
wants to merge 1 commit into from
Closed

Make the sidebar subtitle font slightly smaller #57

wants to merge 1 commit into from

Conversation

ctrueden
Copy link
Contributor

@ctrueden ctrueden commented Jan 3, 2019

Hopefully fixes #56.

@alexdesiqueira
Copy link
Member

Hi @ctrueden, thanks for that!
As you said something in #56, I was wondering... wouldn't it be better if that property continue with an absolute size, in this case font-size: x-small? Would it be too small?

@ctrueden
Copy link
Contributor Author

ctrueden commented Jan 3, 2019

@alexandrejaguar Is x-small an "absolute" size? The CSS documentation just refers to it as "extra small." The fact that small wraps on your layout, but not on many other layouts, makes me wonder about use of these vague terms. Whereas using 11px is an absolute measurement in pixels, no? I am not an expert here, so I vote for just doing what works for everyone as simply as possible. I know that both 11px and x-small look fine on my system, although I find x-small to be rather too small aesthetically, whereas 11px still looks very readable for me.

@stefanv
Copy link
Member

stefanv commented Jan 3, 2019

Thanks, @ctrueden. I've made an adjustment in #58 along with some others. I hope this renders better for both of you now?

@stefanv stefanv closed this Jan 3, 2019
@alexdesiqueira
Copy link
Member

alexdesiqueira commented Jan 3, 2019

@ctrueden yep, x-small is said an absolute size :) https://www.w3.org/wiki/CSS/Properties/font-size
Now it works fine here, try it now @sciunto. Thanks @stefanv!

@ctrueden ctrueden deleted the font-size-fix branch January 3, 2019 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

misalignment of external links on main page
3 participants