Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch vectorized diversity computations #273

Merged
merged 3 commits into from
Feb 27, 2023

Conversation

derekahuang
Copy link
Contributor

@derekahuang derekahuang commented Feb 21, 2023

Opening this PR in response to issue #272

This PR vectorizes diversity.py into a new file diversity_batch.py. All the diversity functions now accept inputs of the form

    y : array of shape (n_samples,):
    y_pred1 : array of shape (n_samples,):
    y_pred2 : array of shape (n_classifiers, n_samples):

@Menelau Menelau merged commit f8e72ba into scikit-learn-contrib:master Feb 27, 2023
@Menelau
Copy link
Collaborator

Menelau commented Feb 27, 2023

@derekahuang Hello,

I've checked the PR today and it looks good. Just found some small pep8 formatting warnings that I already fixed. So I'm merging the PR.

It would be interesting to update the DS methods that use diversity information (DESKNN and DESClustering) to use the new vectorized functions in another PR now that they are available. Do you think you could contribute to that as well?

@derekahuang
Copy link
Contributor Author

@Menelau thanks for merging. and yes i can take a look at updating those methods with the new vectorized function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants