Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster cluster selection #423

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

markopy
Copy link
Contributor

@markopy markopy commented Oct 19, 2020

This PR makes performance improvements to epsilon_search and get_cluster_tree_leaves by optimizing Cython compilation and exploiting how the tree is stored.

The epsilon_search improvements are for eom selection.

For leaf selection epsilon_search is no longer used and the epsilon criteria is checked during get_cluster_tree_leaves. This avoids traversing the tree down to the leaves and then finding the leaves again to traverse up.

@pep8speaks
Copy link

Hello @markopy, Thank you for submitting the Pull Request !

Line 148:17: E126 continuation line over-indented for hanging indent
Line 153:63: W504 line break after binary operator
Line 175:25: E126 continuation line over-indented for hanging indent
Line 284:35: W504 line break after binary operator
Line 285:70: W504 line break after binary operator
Line 294:21: E126 continuation line over-indented for hanging indent
Line 339:47: E126 continuation line over-indented for hanging indent
Line 418:30: W504 line break after binary operator
Line 419:47: W504 line break after binary operator
Line 455:39: E226 missing whitespace around arithmetic operator
Line 471:21: E126 continuation line over-indented for hanging indent
Line 661:13: E126 continuation line over-indented for hanging indent
Line 661:76: W504 line break after binary operator
Line 667:28: E226 missing whitespace around arithmetic operator
Line 709:17: E226 missing whitespace around arithmetic operator
Line 709:36: E226 missing whitespace around arithmetic operator
Line 774:21: E126 continuation line over-indented for hanging indent
Line 796:17: W503 line break before binary operator
Line 876:16: E226 missing whitespace around arithmetic operator
Line 880:25: E126 continuation line over-indented for hanging indent
Line 907:19: E226 missing whitespace around arithmetic operator
Line 920:13: E126 continuation line over-indented for hanging indent
Line 921:13: E123 closing bracket does not match indentation of opening bracket's line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants