Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a positional argument for the cachedir/location #563

Merged
merged 1 commit into from Sep 16, 2022
Merged

Conversation

lmcinnes
Copy link
Collaborator

@lmcinnes lmcinnes commented Sep 16, 2022

The goal is to fix issue #562 by simply calling the joblib Memory class with a positional argument instead of explciitly using the (now deprecated) keyword name cachedir.

@shashankgaur3
Copy link

Is this issue fixed? I am also facing this issue with Bertopic lib. Can't seem to be resolved in 0.8.28

@lmcinnes
Copy link
Collaborator Author

lmcinnes commented Sep 20, 2022 via email

@GuillermoGarciaF
Copy link

Same issue here, my program is crashing due to cachedir deprecated argument.
Would be great if a new patch release is available in pypi.

PS: thank you for the great work! :)

@risicle
Copy link

risicle commented Sep 27, 2022

It would be helpful to make a new release due to https://nvd.nist.gov/vuln/detail/CVE-2022-21797 making it inadvisable for people to continue using joblib 1.1.0.

Greco1899 added a commit to Greco1899/survey_analytics that referenced this pull request Sep 30, 2022
sgbaird added a commit to sparks-baird/mat_discover that referenced this pull request Oct 3, 2022
@dchai76
Copy link

dchai76 commented Oct 10, 2022

I have the same question as everyone else - would it be possible to get a new release so we can get this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants