Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] EHN new metrics #204

Merged
merged 21 commits into from Dec 31, 2016
Merged

[MRG] EHN new metrics #204

merged 21 commits into from Dec 31, 2016

Conversation

@glemaitre
Copy link
Member

@glemaitre glemaitre commented Dec 21, 2016

Reference Issue

Address issue #152

What does this implement/fix? Explain your changes.

There some metrics which are not implemented in scikit-learn but that are usually used for the evaluation on imbalanced set:

  • sensitivity + specificity
  • geometric mean
  • generalized index balanced accuracy
  • F measure <- should be already in sklearn

There already some implementation there which could be put together to fit the scikit-learn API

There is a need for:

  • a classification report for imbalanced data

Any other comments?

@coveralls
Copy link

@coveralls coveralls commented Dec 21, 2016

Coverage Status

Coverage decreased (-0.2%) to 98.66% when pulling 2085360 on glemaitre:metrics into db45249 on scikit-learn-contrib:master.

@coveralls
Copy link

@coveralls coveralls commented Dec 22, 2016

Coverage Status

Coverage decreased (-0.03%) to 98.785% when pulling 0eddca6 on glemaitre:metrics into db45249 on scikit-learn-contrib:master.

@coveralls
Copy link

@coveralls coveralls commented Dec 22, 2016

Coverage Status

Coverage decreased (-0.08%) to 98.734% when pulling ac3d0de on glemaitre:metrics into db45249 on scikit-learn-contrib:master.

@coveralls
Copy link

@coveralls coveralls commented Dec 22, 2016

Coverage Status

Coverage decreased (-0.03%) to 98.786% when pulling e51afd3 on glemaitre:metrics into db45249 on scikit-learn-contrib:master.

@coveralls
Copy link

@coveralls coveralls commented Dec 22, 2016

Coverage Status

Coverage decreased (-0.5%) to 98.304% when pulling 965c5a1 on glemaitre:metrics into db45249 on scikit-learn-contrib:master.

@coveralls
Copy link

@coveralls coveralls commented Dec 22, 2016

Coverage Status

Coverage decreased (-0.1%) to 98.688% when pulling c8cb6d6 on glemaitre:metrics into db45249 on scikit-learn-contrib:master.

@glemaitre glemaitre requested a review from chkoar Dec 23, 2016
@glemaitre
Copy link
Member Author

@glemaitre glemaitre commented Dec 23, 2016

@chkoar I implemented the IBA metric which can take any scoring function as input.
I draft the method but it could be nice to have a second point-of-view on that one,

@coveralls
Copy link

@coveralls coveralls commented Dec 23, 2016

Coverage Status

Coverage decreased (-0.4%) to 98.407% when pulling 4e3f296 on glemaitre:metrics into db45249 on scikit-learn-contrib:master.

@glemaitre
Copy link
Member Author

@glemaitre glemaitre commented Dec 23, 2016

The problem is that all the scoring method do not have the same arguments

@glemaitre
Copy link
Member Author

@glemaitre glemaitre commented Dec 23, 2016

and I need some specific argument for the sensitivity and specificity.
Somehow this is how they build the scorer

@glemaitre glemaitre force-pushed the glemaitre:metrics branch from 4e3f296 to 40c3955 Dec 23, 2016
@coveralls
Copy link

@coveralls coveralls commented Dec 23, 2016

Coverage Status

Coverage decreased (-0.1%) to 98.933% when pulling 40c3955 on glemaitre:metrics into b45a3e4 on scikit-learn-contrib:master.

@glemaitre glemaitre force-pushed the glemaitre:metrics branch from 40c3955 to adcd811 Dec 23, 2016
@coveralls
Copy link

@coveralls coveralls commented Dec 23, 2016

Coverage Status

Coverage decreased (-0.1%) to 98.933% when pulling adcd811 on glemaitre:metrics into 305025b on scikit-learn-contrib:master.

1 similar comment
@coveralls
Copy link

@coveralls coveralls commented Dec 23, 2016

Coverage Status

Coverage decreased (-0.1%) to 98.933% when pulling adcd811 on glemaitre:metrics into 305025b on scikit-learn-contrib:master.

@glemaitre glemaitre force-pushed the glemaitre:metrics branch from adcd811 to 87fa58c Dec 23, 2016
@coveralls
Copy link

@coveralls coveralls commented Dec 23, 2016

Coverage Status

Coverage decreased (-0.1%) to 98.933% when pulling 87fa58c on glemaitre:metrics into fc3f69e on scikit-learn-contrib:master.

@glemaitre glemaitre force-pushed the glemaitre:metrics branch from 87fa58c to 08076d2 Dec 23, 2016
@coveralls
Copy link

@coveralls coveralls commented Dec 23, 2016

Coverage Status

Coverage decreased (-0.1%) to 98.944% when pulling f6d051a on glemaitre:metrics into 75addb8 on scikit-learn-contrib:master.

@coveralls
Copy link

@coveralls coveralls commented Dec 23, 2016

Coverage Status

Coverage decreased (-0.1%) to 98.944% when pulling 49a154f on glemaitre:metrics into 75addb8 on scikit-learn-contrib:master.

@glemaitre glemaitre changed the title [WIP] EHN new metrics [MRG] EHN new metrics Dec 25, 2016
@coveralls
Copy link

@coveralls coveralls commented Dec 25, 2016

Coverage Status

Coverage decreased (-0.1%) to 98.944% when pulling 28ab278 on glemaitre:metrics into 75addb8 on scikit-learn-contrib:master.

@glemaitre glemaitre mentioned this pull request Dec 26, 2016
3 tasks done
@glemaitre glemaitre force-pushed the glemaitre:metrics branch from 28ab278 to 0b36f6e Dec 27, 2016
@chkoar chkoar merged commit ac16d91 into scikit-learn-contrib:master Dec 31, 2016
4 checks passed
4 checks passed
ci/circleci Your tests passed on CircleCI!
Details
code-quality/landscape Code quality decreased by -0.33%
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
christophe-rannou pushed a commit to christophe-rannou/imbalanced-learn that referenced this pull request Apr 3, 2017
glemaitre added a commit to glemaitre/imbalanced-learn that referenced this pull request Jun 15, 2017
glemaitre added a commit to glemaitre/imbalanced-learn that referenced this pull request Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants