Fixes failure in interpolation of ADASYN #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add your fixing to the |
|
Oh and you need to change the tests as well. |
|
I have updated everything, tests passed. |
|
Thanks for you PR |
christophe-rannou
pushed a commit
to christophe-rannou/imbalanced-learn
that referenced
this pull request
Apr 3, 2017
…rib#235) * Fixed ADASYN * Added bug fix to list * Updated tests
glemaitre
pushed a commit
to glemaitre/imbalanced-learn
that referenced
this pull request
Jun 15, 2017
…rib#235) * Fixed ADASYN * Added bug fix to list * Updated tests
glemaitre
pushed a commit
to glemaitre/imbalanced-learn
that referenced
this pull request
Jun 15, 2017
…rib#235) * Fixed ADASYN * Added bug fix to list * Updated tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #232
What does this implement/fix? Explain your changes.
Creation of new sample (x_gen). The generated point x_gen lies in the wrong (opposite) direction than suggested in the ADASYN paper. x_gen should lie between x_i and X[x_i_nn[nn_z], :] (the nearest neighbour)