New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes failure in interpolation of ADASYN #235

Merged
merged 3 commits into from Feb 21, 2017

Conversation

Projects
None yet
3 participants
@Eichhof
Contributor

Eichhof commented Feb 21, 2017

Reference Issue

Fixes #232

What does this implement/fix? Explain your changes.

Creation of new sample (x_gen). The generated point x_gen lies in the wrong (opposite) direction than suggested in the ADASYN paper. x_gen should lie between x_i and X[x_i_nn[nn_z], :] (the nearest neighbour)

@glemaitre

This comment has been minimized.

Member

glemaitre commented Feb 21, 2017

Could you add your fixing to the doc/whats_new.rst.

@glemaitre

This comment has been minimized.

Member

glemaitre commented Feb 21, 2017

Oh and you need to change the tests as well.

@coveralls

This comment has been minimized.

coveralls commented Feb 21, 2017

Coverage Status

Coverage remained the same at 98.934% when pulling 32f409d on Eichhof:master into eccd23f on scikit-learn-contrib:master.

@Eichhof

This comment has been minimized.

Contributor

Eichhof commented Feb 21, 2017

I have updated everything, tests passed.

@glemaitre glemaitre merged commit 537bf78 into scikit-learn-contrib:master Feb 21, 2017

4 checks passed

code-quality/landscape Landscape has completed the code quality check
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 98.934%
Details
@glemaitre

This comment has been minimized.

Member

glemaitre commented Feb 21, 2017

Thanks for you PR

christophe-rannou pushed a commit to christophe-rannou/imbalanced-learn that referenced this pull request Apr 3, 2017

[MRG] FIX Fixes failure in interpolation of ADASYN (scikit-learn-cont…
…rib#235)

* Fixed ADASYN

* Added bug fix to list

* Updated tests

glemaitre added a commit to glemaitre/imbalanced-learn that referenced this pull request Jun 15, 2017

[MRG] FIX Fixes failure in interpolation of ADASYN (scikit-learn-cont…
…rib#235)

* Fixed ADASYN

* Added bug fix to list

* Updated tests

glemaitre added a commit to glemaitre/imbalanced-learn that referenced this pull request Jun 15, 2017

[MRG] FIX Fixes failure in interpolation of ADASYN (scikit-learn-cont…
…rib#235)

* Fixed ADASYN

* Added bug fix to list

* Updated tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment