Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use scipy's logsumexp function #290

Merged
merged 1 commit into from
May 22, 2020
Merged

Use scipy's logsumexp function #290

merged 1 commit into from
May 22, 2020

Conversation

perimosocordiae
Copy link
Contributor

Fixes gh-289.

terrytangyuan
terrytangyuan approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@perimosocordiae
Copy link
Contributor Author

The test failures are real, but unrelated to this change. I'm a bit confused as to when they started happening.

@perimosocordiae perimosocordiae merged commit 2d5a942 into master May 22, 2020
@perimosocordiae perimosocordiae deleted the logsumexp branch May 22, 2020 18:50
@perimosocordiae
Copy link
Contributor Author

Eh, looks like there are a couple errors at head. I'll merge this now and move to the next ones.

@bellet bellet mentioned this pull request Jun 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@perimosocordiae @terrytangyuan