Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflow.md links #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leockl
Copy link

@leockl leockl commented Jan 4, 2020

There are 2 links in workflow.md which doesn't work anymore:

  1. http://contrib.scikit-learn.org/project-name. Perhaps replace this with just the main Github page http://contrib.scikit-learn.org or remove this link completely?
  2. The link under "Upload documentation to your gh-pages branch." (https://help.github.com/articles/creating-project-pages-manually/) doesn't work anymore. Perhaps replace with https://help.github.com/en/github/working-with-github-pages/creating-a-github-pages-site

There are 2 links in workflow.md which doesn't work anymore:
1) http://contrib.scikit-learn.org/project-name. Perhaps replace this with just the main Github page http://contrib.scikit-learn.org or remove this link completely?
2) The link under "Upload documentation to your gh-pages branch." (https://help.github.com/articles/creating-project-pages-manually/) doesn't work anymore. Perhaps replace with https://help.github.com/en/github/working-with-github-pages/creating-a-github-pages-site
@@ -6,7 +6,7 @@ scikit-learn-contrib is a github organization for gathering high-quality scikit-
* Collaboration: volunteers from around the world can join you in improving the project
* Quality: benefit from scikit-learn's experience in producing high-quality machine learning software
* Transfer: most popular estimators can eventually be promoted to scikit-learn
* URL: http://contrib.scikit-learn.org/project-name
* URL: http://contrib.scikit-learn.org
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be rendered as a link. Put it in backticks

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean like this:

* URL: http://contrib.scikit-learn.org

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[http://contrib.scikit-learn.org](http://contrib.scikit-learn.org)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants