-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH - More efficient B.dot
and B.T.dot
in Cox datafit
#168
Merged
mathurinm
merged 18 commits into
scikit-learn-contrib:main
from
Badr-MOUFAD:cox-df-enhanced
Jun 20, 2023
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
1d7de4c
add grad
Badr-MOUFAD 5eb7ab8
add unittest
Badr-MOUFAD 2fdf5b3
fix normalization
Badr-MOUFAD 51dc2b5
clean ups
Badr-MOUFAD d2e6cbb
implement ``EnhancedCox``
Badr-MOUFAD 911cbab
clean ups
Badr-MOUFAD 3d74243
debug script to check ops
Badr-MOUFAD c249c7f
stale commit
Badr-MOUFAD eb42b6a
refactor B_dot to avoid cancellation errors
Badr-MOUFAD 944e0e9
clean ups
Badr-MOUFAD 6ae23fa
mm remarks
Badr-MOUFAD 2279fdd
use ``rtol``
Badr-MOUFAD 5a52e4f
Merge branch 'cox-l2' of https://github.com/Badr-MOUFAD/skglm into co…
Badr-MOUFAD 15d20c4
remove ``OldCox``
Badr-MOUFAD 10d47ce
Merge branch 'main' of https://github.com/scikit-learn-contrib/skglm …
Badr-MOUFAD 6f81ed9
more on docs
Badr-MOUFAD 4e87789
mm remarks
Badr-MOUFAD f376e5f
fix bug indices
Badr-MOUFAD File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!