Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify some time-comsuming examples #13383

Closed
3 of 7 tasks
qinhanmin2014 opened this issue Mar 4, 2019 · 17 comments
Closed
3 of 7 tasks

Simplify some time-comsuming examples #13383

qinhanmin2014 opened this issue Mar 4, 2019 · 17 comments
Labels
Easy Well-defined and straightforward way to resolve good first issue Easy with clear instructions to resolve help wanted

Comments

@qinhanmin2014
Copy link
Member

qinhanmin2014 commented Mar 4, 2019

Some examples are time consuming. I think we should try to simplify them to make these examples more friendly to users and CI.
Examples > 60s (from https://circleci.com/gh/scikit-learn/scikit-learn/50704):

  • plot_coin_segmentation.py: 4.6e+02 sec
  • plot_iterative_imputer_variants_comparison.py: 1.9e+02 sec
  • plot_rbm_logistic_classification.py: 1.5e+02 sec
  • plot_pca_vs_fa_model_selection.py: 1.2e+02 sec
  • plot_image_denoising.py: 1.1e+02 sec
  • plot_digits_pipe.py: 80 sec
  • plot_compare_reduction.py: 69 sec

See #13379 #12929

@qinhanmin2014 qinhanmin2014 added Easy Well-defined and straightforward way to resolve good first issue Easy with clear instructions to resolve help wanted labels Mar 12, 2019
@vcGomez
Copy link

vcGomez commented Mar 16, 2019

Hi! Could I give a try on this? That would be my first issue.

@qinhanmin2014
Copy link
Member Author

Hi! Could I give a try on this? That would be my first issue.

Welcome to contribute :)

@vcGomez
Copy link

vcGomez commented Mar 16, 2019

Thanks! :)

@jnothman
Copy link
Member

@vbarroso, under ./build_tools/circle/build_doc.sh, download the full output as a file, and search for "computation time summary"

@Framartin
Copy link
Contributor

Framartin commented Apr 15, 2019

I started to take a look at the examples/neural_networks/plot_rbm_logistic_classification.py example and I might start working on other mentioned ones. See #13648

xinyuliu12 added a commit to xinyuliu12/scikit-learn that referenced this issue Apr 20, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this issue Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this issue Apr 28, 2019
@anestisdotpy
Copy link

Hello. Could I work on this? I have never contributed to open source before so I am a newbie.
Thanks in advance!

@thomasjpfan
Copy link
Member

Hello. Could I work on this? I have never contributed to open source before so I am a newbie. ...

@anestisdotpy You are welcome to contribute! :)

@anestisdotpy
Copy link

@anestisdotpy You are welcome to contribute! :)

Thank you very much!

@sadepu1915
Copy link

@qinhanmin2014 do we have room to contribute on this ?

@qinhanmin2014
Copy link
Member Author

@qinhanmin2014 do we have room to contribute on this ?

try to pick an example which do not have a PR.

@abhishek-jana
Copy link
Contributor

@qinhanmin2014 I'm new to open source contribution. Can I contribute to this?

@rth
Copy link
Member

rth commented Jul 12, 2019

@abhishek-jana Yes, definitely. Thanks!

@amueller
Copy link
Member

@abhishek-jana sure, just pick on of the examples (say here which) and start working on it.

@thomasjpfan thomasjpfan added this to To do in Sprint Scipy 2019 Jul 13, 2019
@abhishek-jana
Copy link
Contributor

Thanks.

@abhishek-jana
Copy link
Contributor

@abhishek-jana sure, just pick on of the examples (say here which) and start working on it.

I'll be looking into plot_compare_reduction.py thanks.

@Timsaur
Copy link
Contributor

Timsaur commented Jul 13, 2019

working on plot_digits_pipe.py

@qinhanmin2014
Copy link
Member Author

I'm going to close this, according to the latest log https://circleci.com/gh/scikit-learn/scikit-learn/64630, no example takes more than 60s, only two examples take more than 30s (plot_face_recognition.py and plot_sgd_early_stopping.py), which seems acceptable.
Thanks everyone here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy Well-defined and straightforward way to resolve good first issue Easy with clear instructions to resolve help wanted
Projects
No open projects
Development

No branches or pull requests