fix issue #13383: plot_image_denoising.py #13683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…econds to 40 seconds.
NicolasHug
reviewed
Apr 20, 2019
| @@ -31,9 +31,10 @@ | |||
| necessarily related to visualisation. | |||
|
|
|||
| """ | |||
| from time import time | |||
|
|
|||
There was a problem hiding this comment.
please remove this and the import
There was a problem hiding this comment.
sorry, import shouldn't be removed, but please leave it where it was to avoid unnecessary changes
There was a problem hiding this comment.
ok, I will do it.
NicolasHug
approved these changes
Apr 20, 2019
agramfort
approved these changes
Apr 21, 2019
There was a problem hiding this comment.
Here is the old https://scikit-learn.org/stable/auto_examples/decomposition/plot_image_denoising.html
and the new example https://55498-843222-gh.circle-artifacts.com/0/doc/auto_examples/decomposition/plot_image_denoising.html
I don't see the difference visually
|
@xinyuliu12 Thanks for the contribution!!! |
jeremiedbb
pushed a commit
to jeremiedbb/scikit-learn
that referenced
this pull request
Apr 25, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…py (scikit-learn#13683)" This reverts commit ada04b3.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…py (scikit-learn#13683)" This reverts commit ada04b3.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
I tried to address issue #13383
What does this implement/fix? Explain your changes.
improving the performance of example: plot_image_denoising.py. I downsize the running time from 1.1e+02 seconds (from https://circleci.com/gh/scikit-learn/scikit-learn/50704) to 63 seconds (from https://circleci.com/gh/scikit-learn/scikit-learn/55498).
I tried to fix this by further downsampling the input pictures.
Any other comments?