Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot_tree Rotate parameter isn't taken into account #15694

Closed
cmarmo opened this issue Nov 21, 2019 · 1 comment · Fixed by #15806
Closed

Plot_tree Rotate parameter isn't taken into account #15694

cmarmo opened this issue Nov 21, 2019 · 1 comment · Fixed by #15806
Labels
Bug Easy Well-defined and straightforward way to resolve good first issue Easy with clear instructions to resolve help wanted

Comments

@cmarmo
Copy link
Contributor

cmarmo commented Nov 21, 2019

Description

The rotate parameter has no effect in sklearn.tree.plot_tree function.

After checking the code the rotate parameter has been inherited from the sklearn.tree.export_graphviz but has no effect in the code, simply because matplotlib does not manage this option.

Two possibility here

  • rotate can be simply removed
  • a warning is thrown when rotate is activated in plot_tree

I would be happy to propose a PR, just let me know which solution would be preferable

Steps/Code to Reproduce

See #13971

Versions

For scikit-learn >= 0.21:

@TomDLT
Copy link
Member

TomDLT commented Nov 22, 2019

I suggest a deprecation warning

@amueller amueller added Bug Easy Well-defined and straightforward way to resolve good first issue Easy with clear instructions to resolve help wanted labels Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Easy Well-defined and straightforward way to resolve good first issue Easy with clear instructions to resolve help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants