Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG+2] make_circles() now works with odd number of samples, test added #10045

Merged
merged 14 commits into from Nov 11, 2017
Merged

[MRG+2] make_circles() now works with odd number of samples, test added #10045

merged 14 commits into from Nov 11, 2017

Commits on Oct 29, 2017

  1. fixes scikit-learn#10037

    @cbrauneovgude
    cbrauneovgude committed Oct 29, 2017
    Copy the full SHA
    7576278 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2017

  1. tests for scikit-learn#10037, tests for odd number of samples and whe… 

    …ther generated points lie on the expected circles similar to test_make_moons()
    @cbrauneovgude
    cbrauneovgude committed Oct 31, 2017
    Copy the full SHA
    effc6c2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'make_circles' of https://github.com/christianbraune79/s… 

    …cikit-learn into make_circles
    @cbrauneovgude
    cbrauneovgude committed Oct 31, 2017
    Copy the full SHA
    0a101a1 View commit details
    Browse the repository at this point in the history

  3. nasty doubled lines of code removed

    @cbrauneovgude
    cbrauneovgude committed Oct 31, 2017
    Copy the full SHA
    18ee5d8 View commit details
    Browse the repository at this point in the history

  4. changes according to comments in PR

    @cbrauneovgude
    cbrauneovgude committed Oct 31, 2017
    Copy the full SHA
    32b2ffb View commit details
    Browse the repository at this point in the history

  5. assert_equal obviously has a different signature.

    @cbrauneovgude
    cbrauneovgude committed Oct 31, 2017
    Copy the full SHA
    4c99154 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2017

  1. Adjusted documentation for make_circles 

    Added a test to check if really only factors in (0, 1) (excluding borders) are accepted
Adjusted factor check (1.0 was accepted before, though doc said otherwise)
    @cbrauneovgude
    cbrauneovgude committed Nov 3, 2017
    Copy the full SHA
    8a86067 View commit details
    Browse the repository at this point in the history

  2. added entry under "Decomposition, ..." as another datasets-related bu… 

    …g was already mentioned in there.
    @cbrauneovgude
    cbrauneovgude committed Nov 3, 2017
    Copy the full SHA
    9ce24e4 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2017

  1. removed wrong entry

    @cbrauneovgude
    cbrauneovgude committed Nov 9, 2017
    Copy the full SHA
    0f1321a View commit details
    Browse the repository at this point in the history

  2. all tests for odd and even case

    @cbrauneovgude
    cbrauneovgude committed Nov 9, 2017
    Copy the full SHA
    ad1af5d View commit details
    Browse the repository at this point in the history

  3. added final comment

    @cbrauneovgude
    cbrauneovgude committed Nov 9, 2017
    Copy the full SHA
    ad07946 View commit details
    Browse the repository at this point in the history

  4. '107 > 79' fixed

    @cbrauneovgude
    cbrauneovgude committed Nov 9, 2017
    Copy the full SHA
    6126a5c View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2017

  1. refactoring f into factor

    @cbrauneovgude
    cbrauneovgude committed Nov 10, 2017
    Copy the full SHA
    2a62edc View commit details
    Browse the repository at this point in the history

  2. pep8

    @cbrauneovgude
    cbrauneovgude committed Nov 10, 2017
    Copy the full SHA
    e19cecc View commit details
    Browse the repository at this point in the history