[MRG + 1] DOC clean up assorted type specifications #10441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With thanks to the demo of numpy/numpydoc#150
glemaitre
reviewed
Jan 10, 2018
sklearn/datasets/base.py
Outdated
| @@ -212,8 +212,9 @@ def load_data(module_path, data_file_name): | |||
|
|
|||
| Parameters | |||
| ---------- | |||
| data_file_name : String. Name of csv file to be loaded from | |||
| module_path/data/data_file_name. For example 'wine_data.csv'. | |||
| data_file_name : String | |||
There was a problem hiding this comment.
Are we using String or string or str?
There was a problem hiding this comment.
Lowercase is much more common though
glemaitre
reviewed
Jan 10, 2018
| @@ -658,15 +653,15 @@ class MultinomialNB(BaseDiscreteNB): | |||
| class_log_prior_ : array, shape (n_classes, ) | |||
| Smoothed empirical log probability for each class. | |||
|
|
|||
| intercept_ : property | |||
| intercept_ : array, shape (n_classes, ) | |||
There was a problem hiding this comment.
(n_classes,) or (n_classes, )
|
LGTM apart of the 2 comments which are just by curiosity |
glemaitre
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With thanks to the demo of numpy/numpydoc#150
Minor changes only