Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG + 1] DOC clean up assorted type specifications #10441

Merged
merged 2 commits into from Jan 10, 2018

Conversation

Projects
None yet
2 participants
@jnothman
Copy link
Member

jnothman commented Jan 10, 2018

With thanks to the demo of numpy/numpydoc#150

Minor changes only

@@ -212,8 +212,9 @@ def load_data(module_path, data_file_name):
Parameters
----------
data_file_name : String. Name of csv file to be loaded from
module_path/data/data_file_name. For example 'wine_data.csv'.
data_file_name : String

This comment has been minimized.

@glemaitre

glemaitre Jan 10, 2018

Contributor

Are we using String or string or str?

This comment has been minimized.

@jnothman

jnothman Jan 10, 2018

Author Member

Any of the above?

This comment has been minimized.

@jnothman

jnothman Jan 10, 2018

Author Member

Lowercase is much more common though

@@ -658,15 +653,15 @@ class MultinomialNB(BaseDiscreteNB):
class_log_prior_ : array, shape (n_classes, )
Smoothed empirical log probability for each class.
intercept_ : property
intercept_ : array, shape (n_classes, )

This comment has been minimized.

@glemaitre

glemaitre Jan 10, 2018

Contributor

(n_classes,) or (n_classes, )

This comment has been minimized.

@jnothman

jnothman Jan 10, 2018

Author Member

Locally consistent

@glemaitre

This comment has been minimized.

Copy link
Contributor

glemaitre commented Jan 10, 2018

LGTM apart of the 2 comments which are just by curiosity

@glemaitre glemaitre changed the title [MRG] DOC clean up assorted type specifications [MRG + 1] DOC clean up assorted type specifications Jan 10, 2018

@jnothman jnothman merged commit c3bdc0a into scikit-learn:master Jan 10, 2018

0 of 5 checks passed

ci/circleci: python2 Your tests are queued behind your running builds
Details
ci/circleci: python3 Your tests are queued behind your running builds
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
lgtm analysis: Python Fetching Git Commits
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.