-
-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG + 1] DOC clean up assorted type specifications #10441
Conversation
With thanks to the demo of numpy/numpydoc#150
sklearn/datasets/base.py
Outdated
@@ -212,8 +212,9 @@ def load_data(module_path, data_file_name): | |||
|
|||
Parameters | |||
---------- | |||
data_file_name : String. Name of csv file to be loaded from | |||
module_path/data/data_file_name. For example 'wine_data.csv'. | |||
data_file_name : String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we using String or string or str?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any of the above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lowercase is much more common though
@@ -658,15 +653,15 @@ class MultinomialNB(BaseDiscreteNB): | |||
class_log_prior_ : array, shape (n_classes, ) | |||
Smoothed empirical log probability for each class. | |||
|
|||
intercept_ : property | |||
intercept_ : array, shape (n_classes, ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(n_classes,) or (n_classes, )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Locally consistent
LGTM apart of the 2 comments which are just by curiosity |
With thanks to the demo of numpy/numpydoc#150
Minor changes only