Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG+2] OPTICS: add extract_xi method #12077

Merged
merged 107 commits into from
Apr 27, 2019
Merged

[MRG+2] OPTICS: add extract_xi method #12077

merged 107 commits into from
Apr 27, 2019

Commits on Sep 16, 2018

  1. add extract method parameter

    @adrinjalali
    adrinjalali committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    3ab2e63 View commit details
    Browse the repository at this point in the history

  2. change fancy to sqlnk

    @adrinjalali
    adrinjalali committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    7190098 View commit details
    Browse the repository at this point in the history

  3. test for invalid extract_method value

    @adrinjalali
    adrinjalali committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    eb12095 View commit details
    Browse the repository at this point in the history

  4. test easy dbscan

    @adrinjalali
    adrinjalali committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    58913d8 View commit details
    Browse the repository at this point in the history

  5. pep8

    @adrinjalali
    adrinjalali committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    4b06ba8 View commit details
    Browse the repository at this point in the history

  6. add extract_sqlnk

    @adrinjalali
    adrinjalali committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    c9819d2 View commit details
    Browse the repository at this point in the history

  7. mention which parameter is used for which extact method

    @adrinjalali
    adrinjalali committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    61b440f View commit details
    Browse the repository at this point in the history

  8. extractXi in progress

    @adrinjalali
    adrinjalali committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    b8fcc9c View commit details
    Browse the repository at this point in the history

  9. remove R inspired implementation, starting over

    @adrinjalali
    adrinjalali committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    8af9364 View commit details
    Browse the repository at this point in the history

  10. first draft ready

    @adrinjalali
    adrinjalali committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    6e4a467 View commit details
    Browse the repository at this point in the history

  11. improved, but not detecting the last cluster

    @adrinjalali
    adrinjalali committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    b791606 View commit details
    Browse the repository at this point in the history

  12. some edge cases solved

    @adrinjalali
    adrinjalali committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    2695f2b View commit details
    Browse the repository at this point in the history

  13. regions are almost correct, global mib is not

    @adrinjalali
    adrinjalali committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    2b4cd24 View commit details
    Browse the repository at this point in the history

  14. edges between clusters fixed

    @adrinjalali
    adrinjalali committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    b5830e1 View commit details
    Browse the repository at this point in the history

  15. edges between clusters fixed

    @adrinjalali
    adrinjalali committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    08a0f9f View commit details
    Browse the repository at this point in the history

  16. issues of the first test case fixed

    @adrinjalali
    adrinjalali committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    8b182b8 View commit details
    Browse the repository at this point in the history

  17. add extract_xi to OPTICS

    @adrinjalali
    adrinjalali committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    0f0f157 View commit details
    Browse the repository at this point in the history

  18. fix label order issue

    @adrinjalali
    adrinjalali committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    41244a0 View commit details
    Browse the repository at this point in the history

  19. add docstrings

    @adrinjalali
    adrinjalali committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    2bb2c77 View commit details
    Browse the repository at this point in the history

  20. missing - sign

    @adrinjalali
    adrinjalali committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    8ec6df2 View commit details
    Browse the repository at this point in the history

  21. merge optics/choose_extractor

    @adrinjalali
    adrinjalali committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    5ce8952 View commit details
    Browse the repository at this point in the history

  22. continue merge

    @adrinjalali
    adrinjalali committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    2655edb View commit details
    Browse the repository at this point in the history

  23. add xi parameter to OPTICS

    @adrinjalali
    adrinjalali committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    f2fe4e7 View commit details
    Browse the repository at this point in the history

  24. add tests for extract methods with no params given

    @adrinjalali
    adrinjalali committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    9a65082 View commit details
    Browse the repository at this point in the history

  25. add xi to docstrings

    @adrinjalali
    adrinjalali committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    bfbe759 View commit details
    Browse the repository at this point in the history

  26. fix a few more issues with extract_xi integration

    @adrinjalali
    adrinjalali committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    d599a03 View commit details
    Browse the repository at this point in the history

  27. add a xi test

    @adrinjalali
    adrinjalali committed Sep 16, 2018
    Configuration menu
    Copy the full SHA
    baa94f9 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2018

  1. merge master

    @adrinjalali
    adrinjalali committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    bff04ee View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2018

  1. merge master

    @adrinjalali
    adrinjalali committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    f1c6cf1 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2018

  1. Merge remote-tracking branch 'upstream/master' into optics/extractXi

    @adrinjalali
    adrinjalali committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    c16abdc View commit details
    Browse the repository at this point in the history

  2. merge master and choose_extractor

    @adrinjalali
    adrinjalali committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    df261c0 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2019

  1. trying to base on the latest

    @adrinjalali
    adrinjalali committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    02058e9 View commit details
    Browse the repository at this point in the history

  2. trying to base on the latest

    @adrinjalali
    adrinjalali committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    309f4a2 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2019

  1. fix docstring

    @adrinjalali
    adrinjalali committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    a9b3c7e View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2019

  1. Merge remote-tracking branch 'upstream/master' into optics/extractXi

    @adrinjalali
    adrinjalali committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    76f7101 View commit details
    Browse the repository at this point in the history

  2. pep8

    @adrinjalali
    adrinjalali committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    f2b50bd View commit details
    Browse the repository at this point in the history

  3. pep8

    @adrinjalali
    adrinjalali committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    a72c67e View commit details
    Browse the repository at this point in the history

  4. docstring fixes

    @adrinjalali
    adrinjalali committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    93640e0 View commit details
    Browse the repository at this point in the history

  5. better same xi docstring everywhere

    @adrinjalali
    adrinjalali committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    e80d17f View commit details
    Browse the repository at this point in the history

  6. address some of Joel's comments

    @adrinjalali
    adrinjalali committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    d36076f View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/master' into optics/extractXi

    @adrinjalali
    adrinjalali committed Mar 4, 2019
    Configuration menu
    Copy the full SHA
    17de182 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2019

  1. Merge remote-tracking branch 'upstream/master' into optics/extractXi

    @adrinjalali
    adrinjalali committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    9bd42ab View commit details
    Browse the repository at this point in the history

  2. fixes and tests for smaller functions

    @adrinjalali
    adrinjalali committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    a7ba939 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2019

  1. fixing some minor issues and adding more low level tests

    @adrinjalali
    adrinjalali committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    7c091c4 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2019

  1. fix test

    @adrinjalali
    adrinjalali committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    52b409f View commit details
    Browse the repository at this point in the history

  2. test unorered labeling

    @adrinjalali
    adrinjalali committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    613bd5c View commit details
    Browse the repository at this point in the history

  3. add and pass more tests

    @adrinjalali
    adrinjalali committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    15e5dd7 View commit details
    Browse the repository at this point in the history

  4. add comment

    @adrinjalali
    adrinjalali committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    00a2c6f View commit details
    Browse the repository at this point in the history

  5. pep8

    @adrinjalali
    adrinjalali committed Mar 8, 2019
    Configuration menu
    Copy the full SHA
    29c63d4 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2019

  1. randomize input in test

    @adrinjalali
    adrinjalali committed Mar 10, 2019
    Configuration menu
    Copy the full SHA
    edd94ff View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2019

  1. add predecessor correction

    @adrinjalali
    adrinjalali committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    86217ce View commit details
    Browse the repository at this point in the history

  2. pep8

    @adrinjalali
    adrinjalali committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    a077a67 View commit details
    Browse the repository at this point in the history

  3. docstring cleanup and removal of extra flawed 3.b condition

    @adrinjalali
    adrinjalali committed Mar 11, 2019
    Configuration menu
    Copy the full SHA
    392d6cc View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2019

  1. merge min_cluster_size and min_samples

    @adrinjalali
    adrinjalali committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    fd39b77 View commit details
    Browse the repository at this point in the history

  2. add edge case tests and fix an mib issue

    @adrinjalali
    adrinjalali committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    6092a45 View commit details
    Browse the repository at this point in the history

  3. set the min_samples for OPTICS in common tests

    @adrinjalali
    adrinjalali committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    29b61b8 View commit details
    Browse the repository at this point in the history

  4. pep8

    @adrinjalali
    adrinjalali committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    c4629b5 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/master' into optics/extractXi

    @adrinjalali
    adrinjalali committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    4c930c2 View commit details
    Browse the repository at this point in the history

  6. add back optics to docs

    @adrinjalali
    adrinjalali committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    b9d8582 View commit details
    Browse the repository at this point in the history

  7. add optics example

    @adrinjalali
    adrinjalali committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    08d4b58 View commit details
    Browse the repository at this point in the history

  8. fine tune examples, remove prints

    @adrinjalali
    adrinjalali committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    c41da4c View commit details
    Browse the repository at this point in the history

  9. put back min_cluster_size

    @adrinjalali
    adrinjalali committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    c876e1f View commit details
    Browse the repository at this point in the history

  10. fix min_samples to NN

    @adrinjalali
    adrinjalali committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    175c074 View commit details
    Browse the repository at this point in the history

  11. fix examples

    @adrinjalali
    adrinjalali committed Mar 14, 2019
    Configuration menu
    Copy the full SHA
    992c81e View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2019

  1. expose clusters_ as array

    @adrinjalali
    adrinjalali committed Mar 17, 2019
    Configuration menu
    Copy the full SHA
    13bc11b View commit details
    Browse the repository at this point in the history

  2. use utils.shuffle

    @adrinjalali
    adrinjalali committed Mar 17, 2019
    Configuration menu
    Copy the full SHA
    14021ad View commit details
    Browse the repository at this point in the history

  3. add clusters_ test

    @adrinjalali
    adrinjalali committed Mar 17, 2019
    Configuration menu
    Copy the full SHA
    4bd96ab View commit details
    Browse the repository at this point in the history

  4. restructure and use numpy vector operations

    @adrinjalali
    adrinjalali committed Mar 17, 2019
    Configuration menu
    Copy the full SHA
    da1cbec View commit details
    Browse the repository at this point in the history

  5. iterate only through steep points

    @adrinjalali
    adrinjalali committed Mar 17, 2019
    Configuration menu
    Copy the full SHA
    ec2e379 View commit details
    Browse the repository at this point in the history

  6. cleanup the prints

    @adrinjalali
    adrinjalali committed Mar 17, 2019
    Configuration menu
    Copy the full SHA
    b480842 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2019

  1. k, c -> klass, color

    @adrinjalali
    adrinjalali committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    10f6ec2 View commit details
    Browse the repository at this point in the history

  2. address optics_.py comments

    @adrinjalali
    adrinjalali committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    9fc9935 View commit details
    Browse the repository at this point in the history

  3. fix documentation and remove *5 factor from eps

    @adrinjalali
    adrinjalali committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    1d924c9 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/master' into optics/extractXi

    @adrinjalali
    adrinjalali committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    5bfc27b View commit details
    Browse the repository at this point in the history

  5. pep8

    @adrinjalali
    adrinjalali committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    a4533fa View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2019

  1. address some of Joel's comments

    @adrinjalali
    adrinjalali committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    5705daa View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into optics/extractXi

    @adrinjalali
    adrinjalali committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    09e125b View commit details
    Browse the repository at this point in the history

  3. more fixes and tests pass

    @adrinjalali
    adrinjalali committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    c79820b View commit details
    Browse the repository at this point in the history

  4. address more comments

    @adrinjalali
    adrinjalali committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    1df4a75 View commit details
    Browse the repository at this point in the history

  5. finalize fixes and address remaining comments

    @adrinjalali
    adrinjalali committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    3c03e99 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/master' into optics/extractXi

    @adrinjalali
    adrinjalali committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    4d84f94 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2019

  1. address comments

    @adrinjalali
    adrinjalali committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    c031196 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into optics/extractXi

    @adrinjalali
    adrinjalali committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    17e7784 View commit details
    Browse the repository at this point in the history

  3. more addressing comments

    @adrinjalali
    adrinjalali committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    a974376 View commit details
    Browse the repository at this point in the history

  4. fix min_cluster_size as 1

    @adrinjalali
    adrinjalali committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    0b8e161 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2019

  1. apply Hanmin's comments

    @adrinjalali
    adrinjalali committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    293ace7 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2019

  1. merge upstream/master

    @adrinjalali
    adrinjalali committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    68ade1b View commit details
    Browse the repository at this point in the history

  2. fix predecessor issue and apply other comments

    @adrinjalali
    adrinjalali committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    f61516f View commit details
    Browse the repository at this point in the history

  3. pep8

    @adrinjalali
    adrinjalali committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    1ffa5d4 View commit details
    Browse the repository at this point in the history

  4. one of the common tests is already fixed

    @adrinjalali
    adrinjalali committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    ebe0da8 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2019

  1. Merge remote-tracking branch 'upstream/master' into optics/extractXi

    @adrinjalali
    adrinjalali committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    8470539 View commit details
    Browse the repository at this point in the history

  2. update OPTICS's min_samples docstring

    @adrinjalali
    adrinjalali committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    f6fcfc8 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2019

  1. fix docstring

    @adrinjalali
    adrinjalali committed Apr 9, 2019
    Configuration menu
    Copy the full SHA
    4e2e2e7 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2019

  1. Merge remote-tracking branch 'upstream/master' into optics/extractXi

    @adrinjalali
    adrinjalali committed Apr 14, 2019
    Configuration menu
    Copy the full SHA
    34f954a View commit details
    Browse the repository at this point in the history

  2. apply Hanmin's review

    @adrinjalali
    adrinjalali committed Apr 14, 2019
    Configuration menu
    Copy the full SHA
    d778dbe View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2019

  1. Merge remote-tracking branch 'upstream/master' into optics/extractXi

    @adrinjalali
    adrinjalali committed Apr 17, 2019
    Configuration menu
    Copy the full SHA
    9f20ebc View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2019

  1. apply more comments

    @adrinjalali
    adrinjalali committed Apr 18, 2019
    Configuration menu
    Copy the full SHA
    d76b2a5 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2019

  1. Merge remote-tracking branch 'upstream/master' into optics/extractXi

    @adrinjalali
    adrinjalali committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    e1c6086 View commit details
    Browse the repository at this point in the history

  2. apply hanmin's fix for predecessor correction

    @adrinjalali
    adrinjalali committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    1792605 View commit details
    Browse the repository at this point in the history

  3. apply some of hanmin's style

    @adrinjalali
    adrinjalali committed Apr 22, 2019
    Configuration menu
    Copy the full SHA
    44240d5 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2019

  1. Revert "apply hanmin's fix for predecessor correction" 

    This reverts commit 1792605.
    @adrinjalali
    adrinjalali committed Apr 23, 2019
    Configuration menu
    Copy the full SHA
    310c2a0 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2019

  1. fix predecessor correction (again!)

    @adrinjalali
    adrinjalali committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    d83c85d View commit details
    Browse the repository at this point in the history

  2. add comment to test

    @adrinjalali
    adrinjalali committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    c76dee7 View commit details
    Browse the repository at this point in the history

  3. rename predecessor to predecessor_plot where needed

    @adrinjalali
    adrinjalali committed Apr 24, 2019
    Configuration menu
    Copy the full SHA
    c96a32e View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2019

  1. apply more of Hanmin's style

    @adrinjalali
    adrinjalali committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    ab34b53 View commit details
    Browse the repository at this point in the history

  2. credit in whats_new

    @adrinjalali
    adrinjalali committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    be9812b View commit details
    Browse the repository at this point in the history

  3. fix assia's name

    @adrinjalali
    adrinjalali committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    c1e5cde View commit details
    Browse the repository at this point in the history