Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] BUG Fixes duck typing in voting #14287

Merged
merged 5 commits into from
Jul 12, 2019
Merged

[MRG] BUG Fixes duck typing in voting #14287

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1eaeecc
BUG Fixes duck typing in voting
thomasjpfan Jul 7, 2019
ac7268b
TST Fixes test
thomasjpfan Jul 7, 2019
1b40a9f
TST Removes one of the assertions
thomasjpfan Jul 7, 2019
199ac8b
DOC Adds whats new
thomasjpfan Jul 8, 2019
c05d4d3
Merge branch 'master' into fix_duck_typing
qinhanmin2014 Jul 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions sklearn/ensemble/tests/test_voting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,3 +503,14 @@ def test_none_estimator_with_weights(X, y, voter, drop):
voter.fit(X, y, sample_weight=np.ones(y.shape))
y_pred = voter.predict(X)
assert y_pred.shape == y.shape


def test_duck_typing_voting_hard():
clf1 = LogisticRegression(random_state=1)
clf2 = RandomForestClassifier(random_state=1)
clf3 = GaussianNB()
eclf = VotingClassifier(estimators=[
('lr', clf1), ('rf', clf2), ('gnb', clf3)],
voting='hard')
eclf.fit(X, y)
assert not hasattr(eclf, "predict_proba")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would apply even before fit

6 changes: 3 additions & 3 deletions sklearn/ensemble/voting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,9 +313,6 @@ def _collect_probas(self, X):

def _predict_proba(self, X):
"""Predict class probabilities for X in 'soft' voting """
if self.voting == 'hard':
raise AttributeError("predict_proba is not available when"
" voting=%r" % self.voting)
check_is_fitted(self, 'estimators_')
avg = np.average(self._collect_probas(X), axis=0,
weights=self._weights_not_none)
Expand All @@ -335,6 +332,9 @@ def predict_proba(self):
avg : array-like, shape (n_samples, n_classes)
Weighted average probability for each class per sample.
"""
if self.voting == 'hard':
raise AttributeError("predict_proba is not available when"
" voting=%r" % self.voting)
return self._predict_proba

def transform(self, X):
Expand Down