Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] FIX change boolean array-likes indexing in old NumPy version #14510

Merged
merged 8 commits into from Aug 2, 2019

Conversation

@glemaitre
Copy link
Contributor

glemaitre commented Jul 29, 2019

closes #13858

Boolean array-likes and boolean arrays are not indexing the same way for older NumPy version.
Up-to-now it was not an issue, but it seems that we have a bug in ColumnTransformer.

We should make sure that boolean array-likes are converted to arrays for older NumPy version.

@glemaitre glemaitre changed the title FIX change boolean array-likes indexing in old NumPy version [MRG] FIX change boolean array-likes indexing in old NumPy version Jul 30, 2019
@glemaitre

This comment has been minimized.

Copy link
Contributor Author

glemaitre commented Jul 30, 2019

@jnothman @amueller @jorisvandenbossche It seems that the ColumnTransformer would be broken with mask indexing with NumPy < 1.13

I don't know if this is the right fix thought

@jorisvandenbossche

This comment has been minimized.

Copy link
Member

jorisvandenbossche commented Jul 30, 2019

This seems the correct fix to me.

But no plans to bump the numpy version in the next release? (which might make this unneeded)

@glemaitre

This comment has been minimized.

Copy link
Contributor Author

glemaitre commented Jul 30, 2019

But no plans to bump the numpy version in the next release? (which might make this unneeded)

Not if we keep synchronized with the Ubuntu LTS support.

glemaitre added 2 commits Jul 30, 2019
fix
sklearn/utils/__init__.py Outdated Show resolved Hide resolved
Copy link
Contributor

NicolasHug left a comment

LGTM, thought I'm not sure whether it's for version 1.12 or 1.13

Thanks @glemaitre

doc/whats_new/v0.22.rst Outdated Show resolved Hide resolved
sklearn/utils/__init__.py Outdated Show resolved Hide resolved
@thomasjpfan thomasjpfan merged commit 992ed41 into scikit-learn:master Aug 2, 2019
17 checks passed
17 checks passed
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
ci/circleci: deploy Your tests passed on CircleCI!
Details
ci/circleci: doc Your tests passed on CircleCI!
Details
ci/circleci: doc-min-dependencies Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.86%)
Details
codecov/project 96.86% (+<.01%) compared to 4becb71
Details
scikit-learn.scikit-learn Build #20190802.24 succeeded
Details
scikit-learn.scikit-learn (Linux py35_conda_openblas) Linux py35_conda_openblas succeeded
Details
scikit-learn.scikit-learn (Linux py35_ubuntu_atlas) Linux py35_ubuntu_atlas succeeded
Details
scikit-learn.scikit-learn (Linux pylatest_conda_mkl_pandas) Linux pylatest_conda_mkl_pandas succeeded
Details
scikit-learn.scikit-learn (Linux32 py35_ubuntu_atlas_32bit) Linux32 py35_ubuntu_atlas_32bit succeeded
Details
scikit-learn.scikit-learn (Windows py35_pip_openblas_32bit) Windows py35_pip_openblas_32bit succeeded
Details
scikit-learn.scikit-learn (Windows py37_conda_mkl) Windows py37_conda_mkl succeeded
Details
scikit-learn.scikit-learn (macOS pylatest_conda_mkl) macOS pylatest_conda_mkl succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.