[MRG] FIX change boolean array-likes indexing in old NumPy version #14510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
changed the title
|
@jnothman @amueller @jorisvandenbossche It seems that the I don't know if this is the right fix thought |
|
This seems the correct fix to me. But no plans to bump the numpy version in the next release? (which might make this unneeded) |
Not if we keep synchronized with the Ubuntu LTS support. |
amueller
reviewed
Jul 30, 2019
thomasjpfan
reviewed
Aug 1, 2019
NicolasHug
approved these changes
Aug 1, 2019
There was a problem hiding this comment.
LGTM, thought I'm not sure whether it's for version 1.12 or 1.13
Thanks @glemaitre
jnothman
reviewed
Aug 2, 2019
thomasjpfan
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13858
Boolean array-likes and boolean arrays are not indexing the same way for older NumPy version.
Up-to-now it was not an issue, but it seems that we have a bug in
ColumnTransformer.We should make sure that boolean array-likes are converted to arrays for older NumPy version.