Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Fixed reshaping attributes of LogisticRegressionCV #15044

Merged
merged 5 commits into from Oct 3, 2019

Conversation

@NicolasHug
Copy link
Contributor

NicolasHug commented Sep 20, 2019

Fixes #14955

Reshaping was wrong, now fixed.

Not sure how to add a non regression test for that

I am 100% sure that other bugs like that will keep on popping up considering the complexity of the code of LogisticRegressionCV.

NicolasHug added 3 commits Sep 20, 2019
@glemaitre

This comment has been minimized.

Copy link
Contributor

glemaitre commented Sep 20, 2019

as a test, we could check that the score is monotonically increasing (or vice-versa) or something like this on a toy example.

@NicolasHug

This comment has been minimized.

Copy link
Contributor Author

NicolasHug commented Sep 20, 2019

I added a different test that compares avg scores of LogisticRegressionCV with an equivalent LogisticRegrerssion. Can confirm this fails on master

@NicolasHug

This comment has been minimized.

Copy link
Contributor Author

NicolasHug commented Oct 1, 2019

@glemaitre wanna give it another look?

@glemaitre glemaitre added this to TO REVIEW in Guillaume's pet Oct 2, 2019
@glemaitre

This comment has been minimized.

Copy link
Contributor

glemaitre commented Oct 2, 2019

I'll give it a look

Copy link
Member

jnothman left a comment

This looks good

@glemaitre glemaitre merged commit 220e146 into scikit-learn:master Oct 3, 2019
19 checks passed
19 checks passed
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
ci/circleci: deploy Your tests passed on CircleCI!
Details
ci/circleci: doc Your tests passed on CircleCI!
Details
ci/circleci: doc artifact Link to 0/doc/_changed.html
Details
ci/circleci: doc-min-dependencies Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.03%)
Details
codecov/project 96.77% (+0.73%) compared to 5e4b275
Details
scikit-learn.scikit-learn Build #20191001.9 succeeded
Details
scikit-learn.scikit-learn (Linux py35_conda_openblas) Linux py35_conda_openblas succeeded
Details
scikit-learn.scikit-learn (Linux py35_ubuntu_atlas) Linux py35_ubuntu_atlas succeeded
Details
scikit-learn.scikit-learn (Linux pylatest_conda_mkl) Linux pylatest_conda_mkl succeeded
Details
scikit-learn.scikit-learn (Linux pylatest_pip_openblas_pandas) Linux pylatest_pip_openblas_pandas succeeded
Details
scikit-learn.scikit-learn (Linux32 py35_ubuntu_atlas_32bit) Linux32 py35_ubuntu_atlas_32bit succeeded
Details
scikit-learn.scikit-learn (Windows py35_pip_openblas_32bit) Windows py35_pip_openblas_32bit succeeded
Details
scikit-learn.scikit-learn (Windows py37_conda_mkl) Windows py37_conda_mkl succeeded
Details
scikit-learn.scikit-learn (macOS pylatest_conda_mkl) macOS pylatest_conda_mkl succeeded
Details
@glemaitre

This comment has been minimized.

Copy link
Contributor

glemaitre commented Oct 3, 2019

Thanks @NicolasHug

@glemaitre glemaitre moved this from TO REVIEW to MERGED in Guillaume's pet Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.