[MRG] Fixed reshaping attributes of LogisticRegressionCV #15044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
as a test, we could check that the score is monotonically increasing (or vice-versa) or something like this on a toy example. |
|
I added a different test that compares avg scores of LogisticRegressionCV with an equivalent LogisticRegrerssion. Can confirm this fails on master |
|
@glemaitre wanna give it another look? |
|
I'll give it a look |
|
Thanks @NicolasHug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14955
Reshaping was wrong, now fixed.
Not sure how to add a non regression test for thatI am 100% sure that other bugs like that will keep on popping up considering the complexity of the code of
LogisticRegressionCV.