Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Fixed reshaping attributes of LogisticRegressionCV #15044

Merged
merged 5 commits into from Oct 3, 2019

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Sep 20, 2019

Fixes #14955

Reshaping was wrong, now fixed.

Not sure how to add a non regression test for that

I am 100% sure that other bugs like that will keep on popping up considering the complexity of the code of LogisticRegressionCV.

@glemaitre
Copy link
Contributor

@glemaitre glemaitre commented Sep 20, 2019

as a test, we could check that the score is monotonically increasing (or vice-versa) or something like this on a toy example.

@NicolasHug
Copy link
Member Author

@NicolasHug NicolasHug commented Sep 20, 2019

I added a different test that compares avg scores of LogisticRegressionCV with an equivalent LogisticRegrerssion. Can confirm this fails on master

@NicolasHug
Copy link
Member Author

@NicolasHug NicolasHug commented Oct 1, 2019

@glemaitre wanna give it another look?

@glemaitre glemaitre added this to TO REVIEW in Guillaume's pet Oct 2, 2019
@glemaitre
Copy link
Contributor

@glemaitre glemaitre commented Oct 2, 2019

I'll give it a look

Copy link
Member

@jnothman jnothman left a comment

This looks good

@glemaitre glemaitre merged commit 220e146 into scikit-learn:master Oct 3, 2019
19 checks passed
@glemaitre
Copy link
Contributor

@glemaitre glemaitre commented Oct 3, 2019

Thanks @NicolasHug

@glemaitre glemaitre moved this from TO REVIEW to MERGED in Guillaume's pet Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants