Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT Makes sure mask is private #15091

Merged
merged 1 commit into from
Sep 25, 2019
Merged

MAINT Makes sure mask is private #15091

merged 1 commit into from
Sep 25, 2019

Conversation

thomasjpfan
Copy link
Member

utils.mask was not released and was introduced in #12852

This PR makes it even more private.

amueller
amueller approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@amueller amueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so private!

rth
rth approved these changes Sep 25, 2019
View reviewed changes
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No one will find it now :)

@rth rth changed the title [MRG] MAINT Makes sure mask is private MAINT Makes sure mask is private Sep 25, 2019
@rth rth merged commit 3b9f942 into scikit-learn:master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amueller amueller amueller approved these changes

@rth rth rth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasjpfan @amueller @rth