FIX SparseCoder set_params works correctly #15236
Closed
+44
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 13, 2019 14:18
The way that SparseCoder was initialized led to a bug so that set_params on the dictionary had actually no effect. I added a test that breaks on the current master, and the fix to make the test pass.
jnothman
reviewed
Oct 15, 2019
| self.positive_code = positive_code | ||
|
|
||
| @property | ||
| def n_components(self): |
There was a problem hiding this comment.
_set_sparse_coding_params used to set self.n_components as inferred from dictionary. Since that no longer happens, I added the property in case n_components is still required.
| @@ -1018,12 +1018,18 @@ def __init__(self, dictionary, transform_algorithm='omp', | |||
| transform_n_nonzero_coefs=None, transform_alpha=None, | |||
| split_sign=False, n_jobs=None, positive_code=False, | |||
| transform_max_iter=1000): | |||
| self._set_sparse_coding_params(dictionary.shape[0], | |||
There was a problem hiding this comment.
Is this helper method still used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug with
SparseCoder.set_params. One of the consequencesof this bug is that, for instance, grid searching on the dictionary has no effect.
Reference Issues/PRs
The way that
SparseCoderwas initialized led to a bug so thatset_paramson the dictionary had actually no effect. I added a testthat breaks on the current master, and the fix to make the test pass.
What does this implement/fix? Explain your changes.
Any other comments?