Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX SparseCoder set_params works correctly #15236

Closed
wants to merge 2 commits into from
Closed

FIX SparseCoder set_params works correctly #15236

wants to merge 2 commits into from

Commits on Oct 13, 2019

  1. FIX SparseCoder set_params works correctly 

    The way that SparseCoder was initialized led to a bug so that
set_params on the dictionary had actually no effect. I added a test
that breaks on the current master, and the fix to make the test pass.
    BenjaminBossan committed Oct 13, 2019
    Configuration menu
    Copy the full SHA
    1e96eb1 View commit details
    Browse the repository at this point in the history

  2. Add test for n_components property in SparseCoder

    BenjaminBossan committed Oct 13, 2019
    Configuration menu
    Copy the full SHA
    2666513 View commit details
    Browse the repository at this point in the history