Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] MNT Make modules private in neighbors #15322

Merged
merged 5 commits into from Oct 23, 2019
Merged

[MRG] MNT Make modules private in neighbors #15322

merged 5 commits into from Oct 23, 2019

Conversation

thomasjpfan
Copy link
Member

@thomasjpfan thomasjpfan commented Oct 21, 2019 •
edited

Reference Issues/PRs

Partially addresses #9250

Any other comments?

CC @NicolasHug @adrinjalali

@NicolasHug NicolasHug mentioned this pull request Oct 21, 2019
Closed
@thomasjpfan thomasjpfan changed the title [MRG] MNT Deprecated paths in neighbors [MRG] MNT Make modules private in neighbors Oct 21, 2019
NicolasHug
NicolasHug reviewed Oct 21, 2019
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what to do with binary_tree.pxi? I think we could deprecate it like the others and move it to _binary_tree.pyx?

quad_tree and typedefs seem to be missing from the list of deprecated files

@thomasjpfan
Copy link
Member Author

binary_tree is not importable on master

@adrinjalali adrinjalali merged commit 62aee06 into scikit-learn:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thomasjpfan @NicolasHug @adrinjalali