-
-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH Adds pandas IntegerArray support to check_array #16508
Merged
ogrisel
merged 24 commits into
scikit-learn:master
from
thomasjpfan:pandas_pd_na_support
Apr 28, 2020
Merged
Changes from 21 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
b936ffb
ENH Adds support for pandas IntegerArray
thomasjpfan 625eea2
DOC Adds comment regarding dtype
thomasjpfan 371d16e
ENH Checks for type explicity
thomasjpfan da39b41
CLN Address comments
thomasjpfan 8bd32d8
Merge remote-tracking branch 'upstream/master' into pandas_pd_na_support
thomasjpfan f1d0a3e
Merge remote-tracking branch 'upstream/master' into pandas_pd_na_support
thomasjpfan 50a0de9
CLN Adds support for unsigned
thomasjpfan 0f43b16
CLN Clean up unneeded code
thomasjpfan a634d3a
CLN Address comments
thomasjpfan cc21a5f
CLN Slightly nicer
thomasjpfan 5ef3985
Merge remote-tracking branch 'upstream/master' into pandas_pd_na_support
thomasjpfan c6273a5
DOC Adds whats new
thomasjpfan 679c08e
TST Adds explicit checking
thomasjpfan 0318eb9
CLN Suggestion
thomasjpfan 752ed5a
Merge remote-tracking branch 'upstream/master' into pandas_pd_na_support
thomasjpfan 39dc7a6
CLN Adds test for imputers
thomasjpfan c861463
TST Adds test for dtypes
thomasjpfan 8ff73e4
ENH Better dtype checking
thomasjpfan 690cfdb
DOC Adds note regarding pandas integerarray
thomasjpfan 77bf3b5
TST Fix
thomasjpfan 38873e6
Merge branch 'master' into pandas_pd_na_support
jnothman e2b699c
Apply suggestions from code review
ogrisel 09d69b5
DOC Update to pands nullable integer dtype with missing values
thomasjpfan 774eaba
Merge branch 'master' into pandas_pd_na_support
ogrisel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggestion, but in general we try to speak about the dtype, as "IntegerArray" is only used under the hood and not directly visible to most users (unless you access the underlying values of a single column), and thus not necessarily a term that users are familiar with
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(but it makes it more verbose, though, ..)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorisvandenbossche that's a good point. There are other occurrence of the "IntegerArray" in this PR. I think we should covert them all to "pandas' nullable integer dtype/values/column/dataframe" depending on the context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thomasjpfan if you agree with this proposal, I can give it a shot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the PR with removing the "IntegerArray" wording in place of "pandas' nullable ..."