DOC DataConversionWarning: Add example to doc of DataCon… #16704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielvangelder
changed the title
thomasjpfan
reviewed
Mar 17, 2020
There was a problem hiding this comment.
@danielbarkhorn I see this is your first time contributing, welcome!
sklearn/exceptions.py
Outdated
| >>> with warnings.catch_warnings(record=True) as w: | ||
| ... try: | ||
| ... # Will trigger warning as metric requires X.dtype=bool | ||
| ... D = pairwise_distances(X, metric="jaccard") |
There was a problem hiding this comment.
May we use column_or_1d instead as an example that issues a DataConversionWarning warning? I think users would run into that situation more often.
danielvangelder
changed the title
thomasjpfan
reviewed
Apr 5, 2020
jnothman
approved these changes
Apr 19, 2020
jnothman
changed the title
|
Thanks @toondeboer |
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
One of the TODO's in #3846, the
DataConversionWarningclass needed an example in the doc. Therefore I took inspiration from the example in theFitFailedWarningclass doc.What does this implement/fix? Explain your changes.
Adds an example to the class description where the warning is triggered.
Any other comments?
This is my first PR to scikit-learn so I'm happy to hear if any changes are necessary!