API Deprecate positional arguments in random_projection #16995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinjalali
approved these changes
Apr 22, 2020
NicolasHug
approved these changes
Apr 22, 2020
sklearn/random_projection.py
Outdated
| @@ -48,7 +49,8 @@ | |||
| "johnson_lindenstrauss_min_dim"] | |||
|
|
|||
|
|
|||
| def johnson_lindenstrauss_min_dim(n_samples, eps=0.1): | |||
| @_deprecate_positional_args | |||
| def johnson_lindenstrauss_min_dim(n_samples, *, eps=0.1): | |||
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
…#16995) * API Deprecate positional arguments in random_projection * CLN Address comments
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
…#16995) * API Deprecate positional arguments in random_projection * CLN Address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Toward #15005