Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH Allow isotonic reg 2d input with 1 feature (GH15012) #17379
ENH Allow isotonic reg 2d input with 1 feature (GH15012) #17379
Changes from 17 commits
2a6ae7f
b832a11
379dd23
90c4da5
0424c32
b3f1dfc
05eab7e
f562f55
b507b1c
c9b8fd9
1604cc6
1b8f71b
75728d4
8d45ec6
99aa688
17323ef
1f5290f
c8e3670
066fd9d
10e4fd2
d5d27da
ee3e4f5
98f8db2
0a5f65e
102e587
ebebdf5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also check that the estimator attributes match in shape. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jnothman, thanks for review. Are you referring to the
_necessary_X_
and_necessary_y_
attributes? I have added checking for these two attributes. If it's something else, can you give a bit more details what you mean?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I meant the public attributes
X_min_
,X_max_
, etc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @jnothman, sorry for the late reply. I have added the checks as requested. Could you review again?