-
-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX Fixes visualization for nested meta-estimators #21310
Conversation
for key, est in estimator.get_params().items() | ||
if ( | ||
"__" not in key | ||
and hasattr(est, "get_params") | ||
and hasattr(est, "fit") | ||
and callable(est.fit) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't get_params be called with deep=False ?
I guess it's what "__" not in key
is suppose to mimic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree setting deep=False
works here. I updated the PR with your suggestion.
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
Reference Issues/PRs
Fixes #21267
What does this implement/fix? Explain your changes.
This PR changes the implementation a little to only work on estimators. This fixes the original issue:
this PR
main
Any other comments?
There was also issues with nesting meta-estimators that is resolved:
this PR
main