-
-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT Use check_scalar in AdaBoostRegressor #21605
Merged
thomasjpfan
merged 11 commits into
scikit-learn:main
from
genvalen:AdaBoostRegressor_add_check_scaler
Dec 16, 2021
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
12e1627
Add tests
genvalen 8482313
Validate scalar parameters with check_scalar
genvalen 68fd69c
Merge branch 'main' of https://github.com/scikit-learn/scikit-learn i…
genvalen 9b8a673
Move checks from AdaBoostRegressor to BaseWeightBoosting
genvalen 28e2af0
Update tests
genvalen 0335ea2
Remove redundant checks from AdaBoostClassifer
genvalen 94d420d
Merge branch 'main' of https://github.com/scikit-learn/scikit-learn i…
genvalen 2cabe56
Minor clean up and format with black
genvalen 563c5f0
Update sklearn/ensemble/tests/test_weight_boosting.py
genvalen 2ae607d
Update sklearn/ensemble/tests/test_weight_boosting.py
genvalen 360e7d0
Ensure validation happens in
genvalen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reshamas: I should have been clearer.
Here for instance, there's a check for
ValueErrors
being raised but their error messages aren't checked.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we re-open this one? Error messages are important and helpful, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we go: #22144