Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Use check_scalar in AdaBoostRegressor #21605

Merged
merged 11 commits into from
Dec 16, 2021
Merged

MNT Use check_scalar in AdaBoostRegressor #21605

merged 11 commits into from
Dec 16, 2021

Commits on Nov 9, 2021

  1. Add tests

    @genvalen
    genvalen committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    12e1627 View commit details
    Browse the repository at this point in the history

  2. Validate scalar parameters with check_scalar

    @genvalen
    genvalen committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    8482313 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2021

  1. Merge branch 'main' of https://github.com/scikit-learn/scikit-learn i… 

    …nto AdaBoostRegressor_add_check_scaler
    @genvalen
    genvalen committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    68fd69c View commit details
    Browse the repository at this point in the history

  2. Move checks from AdaBoostRegressor to BaseWeightBoosting

    @genvalen
    genvalen committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    9b8a673 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2021

  1. Update tests

    @genvalen
    genvalen committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    28e2af0 View commit details
    Browse the repository at this point in the history

  2. Remove redundant checks from AdaBoostClassifer

    @genvalen
    genvalen committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    0335ea2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of https://github.com/scikit-learn/scikit-learn i… 

    …nto AdaBoostRegressor_add_check_scaler
    @genvalen
    genvalen committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    94d420d View commit details
    Browse the repository at this point in the history

  4. Minor clean up and format with black

    @genvalen
    genvalen committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    2cabe56 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2021

  1. Update sklearn/ensemble/tests/test_weight_boosting.py 

    Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
    @genvalen @thomasjpfan
    genvalen and thomasjpfan committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    563c5f0 View commit details
    Browse the repository at this point in the history

  2. Update sklearn/ensemble/tests/test_weight_boosting.py 

    Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
    @genvalen @thomasjpfan
    genvalen and thomasjpfan committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    2ae607d View commit details
    Browse the repository at this point in the history

  3. Ensure validation happens in

    @genvalen
    genvalen committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    360e7d0 View commit details
    Browse the repository at this point in the history