ENH Check for nonfinite coordinate descent #22148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Preining <norbert@preining.info>
chritter
force-pushed
the
issue17925-checkfinite-coordinate-descent
branch
from
9272893
to
123f5b2
Compare
thomasjpfan
reviewed
Jan 9, 2022
Co-authored-by: Norbert Preining <norbert@preining.info>
norbusan
force-pushed
the
issue17925-checkfinite-coordinate-descent
branch
from
9dc3a4f
to
6224abb
Compare
…ithub.com/norbusan/scikit-learn into issue17925-checkfinite-coordinate-descent
…nto issue17925-checkfinite-coordinate-descent
thomasjpfan
reviewed
Jan 15, 2022
thomasjpfan
reviewed
Jan 15, 2022
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
changed the title
thomasjpfan
changed the title
lorentzenchr
approved these changes
Jan 17, 2022
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
|
@lorentzenchr Thank you for the review and suggestions which were adopted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Addresses #17925.
What does this implement/fix? Explain your changes.
This implements check for non-finite values of estimator parameters: as produced from coordinate descent for linear models.
Any other comments?
Work done with @norbusan.
Originally part of larger PR #22092