[WIP] grid_search: add sample_weight support

[ndawe]

No description provided.

[jnothman]

Exciting! But almost anything that changes in grid_search API should also change in cross_val_score. Or rather, they should be refactored as in #2079.

Also: needs tests.

[ndawe]

Thanks for the quick review @jnothman! I will implement the changes in cross_val_score and add some tests.

[jnothman]

It wasn't a full review yet, I'll admit, though I'm excited for the
feature. I'll have time for that in a couple of weeks. I really would like
to see the parallel code deduplicated though.

On Fri, Aug 23, 2013 at 5:47 AM, Noel Dawe notifications@github.com wrote:

Thanks for the quick review @jnothman https://github.com/jnothman! I
will implement the changes in cross_val_score and add some tests.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2382#issuecomment-23119508
.

[ndawe]

@jnothman ok, maybe I can ping someone else for a review in the meantime after implementing your suggestions.

[ndawe]

I am going to merge this PR with #1574 since I need those weighted score metrics for the unit tests.

[ndawe]

Continuing in #1574 where grid search unit tests have been implemented.