ENH Makes OneToOneFeatureMixin and ClassNamePrefixFeaturesOutMixin public #24688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glemaitre
approved these changes
Oct 18, 2022
|
Merging then. I solved the conflict that is resulting from the update of the |
glemaitre
added a commit
to glemaitre/scikit-learn
that referenced
this pull request
Oct 31, 2022
…blic (scikit-learn#24688) Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Follow up to #23734
What does this implement/fix? Explain your changes.
This PR adds
OneToOneFeatureMixinandClassNamePrefixFeaturesOutMixinas public API. This makes it easier to defineget_feature_names_outwhich enables theset_outputAPI.Any other comments?
There was a discussion on twitter about third party adoption of the
set_outputAPI.