Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] FABIA biclustering algorithm #2476

Closed
wants to merge 3 commits into from
Closed

Conversation

untom
Copy link
Contributor

@untom untom commented Sep 24, 2013

This PR adds the FABIA biclustering algorithm to sklearn, as discussed off-list with @kemaleren (and his mentors).

As this is my first larger contribution, please point out any rough edges I might have overlooked in the PR process.

Things worth mentioning:

  • Two of the included tests are skipped because of their long running time, as they are not simple functionality tests but rather reproduce part of a simulation study from the original paper (e.g. they make sure results are up to par with the R reference implementation). Also, these two tests rely on Issue sklearn.metrics.consensus_score potentially gives wrong results #2445 being fixed.
  • I couldn't build the docs due what seems to be something related to Issue Cannot build docs using docutils 0.9.1 #1140, but I'm unable to fix it on my computer :( So I couldn't verify if there are formatting errors in the accompanying documentation.
  • I haven't gotten around writing a good example yet (ideas welcome!)
  • There's no benchmarking included (as the reference implementation is in R). However this implementation runs faster than the pure R version of FABIA (part of the reference package), but slower than the current reference implementation (which is C wrapped in R) by a factor of 2-5 (depending on data size).

References:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant