Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
[MRG] Added n_iter_ parameters across all iterative solvers #3360
Added a n_iter parameter across all iterative solvers that have a max_iter parameter.
Models that have the max_iter parameter.
Dependent on external solvers like arpack, so cannot access the iter param
Dependent on LibSVM
referenced this pull request
Jul 14, 2014
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
I agree with Alex that maintaining API compatibility is extremely important. In order to maintain this compatibility and at the same time return this parameters you would need to add a keyword to public functions such as
For the private functions my opinion is that it's OK to break compatibility and just return the number of iterations as you are currently doing.