New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] Make cython compiler directives global #6664

Merged

ogrisel merged 1 commit into scikit-learn:master from yenchenlin:make-cython-compiler-directives-global

Apr 15, 2016

Contributor

yenchenlin commented Apr 15, 2016

This PR applies cython compiler directives in the module level for utils/sparsefuncs_fast.pyx
and therefore reduce redundant code.

Also, it fixes misplaced docstrings.

ping @MechCoder @jnothman @rvraghav93


          Make cython compiler directives global

566a0e7

Member

ogrisel commented Apr 15, 2016

LGTM, merging directly as this is a quickfix.

ogrisel merged commit b094a59 into scikit-learn:master

Member

ogrisel commented Apr 15, 2016

Thanks @yenchenlin1994!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet