Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] add warning when importing old or new pickle. #7248

Merged
merged 4 commits into from
Sep 10, 2016
Merged

[MRG] add warning when importing old or new pickle. #7248

merged 4 commits into from
Sep 10, 2016

Commits on Sep 8, 2016

  1. add warning when importing old or new pickle. 

    add tests for pickle warning

add test that loading something stored with no custom __getstate__ will still work (and raise a warning)

added "within sklearn" check, included estimator name in warning message.

add that pickle warnings only apply to sklearn estimators.

changed tests to be threadsave and contain no monkey business
    @amueller
    amueller committed Sep 8, 2016
    Configuration menu
    Copy the full SHA
    b28cfbc View commit details
    Browse the repository at this point in the history

  2. make IsotonicRegression __setstate__ and __getstate__ call super

    @amueller
    amueller committed Sep 8, 2016
    Configuration menu
    Copy the full SHA
    c980d98 View commit details
    Browse the repository at this point in the history

  3. conditional test for version in common tests

    @amueller
    amueller committed Sep 8, 2016
    Configuration menu
    Copy the full SHA
    106c397 View commit details
    Browse the repository at this point in the history

  4. don't use __version__, use _sklearn_version

    @amueller
    amueller committed Sep 8, 2016
    Configuration menu
    Copy the full SHA
    461ae84 View commit details
    Browse the repository at this point in the history