Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG + 1] Revive "don't set trailing _ attrs in __init__" PR #7464

Merged

Commits on Dec 9, 2016

  1. MAINT/TST: don't set trailing "_" attrs in __init__

    NOTE: code uses getattr(self, "someattr_", None) is None instead
    of hasattr, in an attempt to be backwards compatible with pickled
    estimators that have these attributes.
    larsmans authored and lesteve committed Dec 9, 2016
    Configuration menu
    Copy the full SHA
    8a0987e View commit details
    Browse the repository at this point in the history
  2. Fix merge gone wrong

    lesteve committed Dec 9, 2016
    Configuration menu
    Copy the full SHA
    dd744da View commit details
    Browse the repository at this point in the history
  3. Require that hasattr(estimator, something_) is always False before fit

    In particular for properties ending with an underscore, that means that
    their getter must raise an AttributeError.
    
    Use check_is_fitted where appropriate.
    lesteve committed Dec 9, 2016
    Configuration menu
    Copy the full SHA
    d113db4 View commit details
    Browse the repository at this point in the history
  4. Better error message

    lesteve committed Dec 9, 2016
    Configuration menu
    Copy the full SHA
    e61436b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a0ff671 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cab960a View commit details
    Browse the repository at this point in the history
  7. Tweak error message further

    lesteve committed Dec 9, 2016
    Configuration menu
    Copy the full SHA
    c8c140c View commit details
    Browse the repository at this point in the history
  8. Improve whats_new

    lesteve committed Dec 9, 2016
    Configuration menu
    Copy the full SHA
    819ff90 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2016

  1. Configuration menu
    Copy the full SHA
    1b91192 View commit details
    Browse the repository at this point in the history