-
-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG + 1] Revive "don't set trailing _ attrs in __init__" PR #7464
Merged
jnothman
merged 9 commits into
scikit-learn:master
from
lesteve:larsmans-test-fit-attributes-in-init
Dec 12, 2016
Merged
[MRG + 1] Revive "don't set trailing _ attrs in __init__" PR #7464
jnothman
merged 9 commits into
scikit-learn:master
from
lesteve:larsmans-test-fit-attributes-in-init
Dec 12, 2016
Commits on Dec 9, 2016
-
MAINT/TST: don't set trailing "_" attrs in __init__
NOTE: code uses getattr(self, "someattr_", None) is None instead of hasattr, in an attempt to be backwards compatible with pickled estimators that have these attributes.
Configuration menu - View commit details
-
Copy full SHA for 8a0987e - Browse repository at this point
Copy the full SHA 8a0987eView commit details -
Configuration menu - View commit details
-
Copy full SHA for dd744da - Browse repository at this point
Copy the full SHA dd744daView commit details -
Require that hasattr(estimator, something_) is always False before fit
In particular for properties ending with an underscore, that means that their getter must raise an AttributeError. Use check_is_fitted where appropriate.
Configuration menu - View commit details
-
Copy full SHA for d113db4 - Browse repository at this point
Copy the full SHA d113db4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e61436b - Browse repository at this point
Copy the full SHA e61436bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a0ff671 - Browse repository at this point
Copy the full SHA a0ff671View commit details -
Configuration menu - View commit details
-
Copy full SHA for cab960a - Browse repository at this point
Copy the full SHA cab960aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c8c140c - Browse repository at this point
Copy the full SHA c8c140cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 819ff90 - Browse repository at this point
Copy the full SHA 819ff90View commit details
Commits on Dec 12, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 1b91192 - Browse repository at this point
Copy the full SHA 1b91192View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.