[MRG+2] addresses #8509 improvements to f_regression documentation #8548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raghavrv
changed the title
… see all line from another function, the line is over by a period, does not make sense to newline that.
|
Thanks ! It looks much better to me! |
NelleV
changed the title
jnothman
reviewed
Mar 7, 2017
| that is, ((X[:, i] - mean(X[:, i])) * (y - mean_y)) / (std(X[:, i]) * | ||
| std(y)). | ||
| 2. It is converted to an F score then to a p-value. | ||
|
|
||
| Read more in the :ref:`User Guide <univariate_feature_selection>`. | ||
| For more on usage see the :ref:`User Guide <univariate_feature_selection>`. |
There was a problem hiding this comment.
Not sure about this change. Nearly every class/function docstring includes "Read more in the".
There was a problem hiding this comment.
I changed it to make it more clear what the user guide provides in relation to the content in the docstring. "Read more" left me to expect more information about f regression, but it actually is a page on feature selection. I didn't notice that the specific "read more in" was used everywhere, consistency might be worth keeping.
|
No I think you're right
…On 7 Mar 2017 3:01 pm, "Sarah Brown" ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In sklearn/feature_selection/univariate_selection.py
<#8548 (comment)>
:
> that is, ((X[:, i] - mean(X[:, i])) * (y - mean_y)) / (std(X[:, i]) *
std(y)).
2. It is converted to an F score then to a p-value.
- Read more in the :ref:`User Guide <univariate_feature_selection>`.
+ For more on usage see the :ref:`User Guide <univariate_feature_selection>`.
I changed it to make it more clear what the user guide provides in
relation to the content in the docstring. "Read more" left me to expect
more information about f regression, but it actually is a page on feature
selection. I didn't notice that the specific "read more in" was used
everywhere, consistency might be worth keeping.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#8548 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz65Pu63zej54fkso0k3TDLYcTI0Xsks5rjNazgaJpZM4MU06Y>
.
|
|
Thanks! |
Closed
herilalaina
pushed a commit
to herilalaina/scikit-learn
that referenced
this pull request
Mar 26, 2017
…mentation (scikit-learn#8548) * clarify role of the function and streamline introduction * added feature selection methods to see also * completed see also * fixed pep related formatting for flake8checks. * fixed extra whitespace flake8 problems, remaining failure is a copied see all line from another function, the line is over by a period, does not make sense to newline that. * one more whitespace * FIX small pep8 error.
massich
pushed a commit
to massich/scikit-learn
that referenced
this pull request
Apr 26, 2017
…mentation (scikit-learn#8548) * clarify role of the function and streamline introduction * added feature selection methods to see also * completed see also * fixed pep related formatting for flake8checks. * fixed extra whitespace flake8 problems, remaining failure is a copied see all line from another function, the line is over by a period, does not make sense to newline that. * one more whitespace * FIX small pep8 error.
Sundrique
pushed a commit
to Sundrique/scikit-learn
that referenced
this pull request
Jun 14, 2017
…mentation (scikit-learn#8548) * clarify role of the function and streamline introduction * added feature selection methods to see also * completed see also * fixed pep related formatting for flake8checks. * fixed extra whitespace flake8 problems, remaining failure is a copied see all line from another function, the line is over by a period, does not make sense to newline that. * one more whitespace * FIX small pep8 error.
NelleV
pushed a commit
to NelleV/scikit-learn
that referenced
this pull request
Aug 11, 2017
…mentation (scikit-learn#8548) * clarify role of the function and streamline introduction * added feature selection methods to see also * completed see also * fixed pep related formatting for flake8checks. * fixed extra whitespace flake8 problems, remaining failure is a copied see all line from another function, the line is over by a period, does not make sense to newline that. * one more whitespace * FIX small pep8 error.
paulha
pushed a commit
to paulha/scikit-learn
that referenced
this pull request
Aug 19, 2017
…mentation (scikit-learn#8548) * clarify role of the function and streamline introduction * added feature selection methods to see also * completed see also * fixed pep related formatting for flake8checks. * fixed extra whitespace flake8 problems, remaining failure is a copied see all line from another function, the line is over by a period, does not make sense to newline that. * one more whitespace * FIX small pep8 error.
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
…mentation (scikit-learn#8548) * clarify role of the function and streamline introduction * added feature selection methods to see also * completed see also * fixed pep related formatting for flake8checks. * fixed extra whitespace flake8 problems, remaining failure is a copied see all line from another function, the line is over by a period, does not make sense to newline that. * one more whitespace * FIX small pep8 error.
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
…mentation (scikit-learn#8548) * clarify role of the function and streamline introduction * added feature selection methods to see also * completed see also * fixed pep related formatting for flake8checks. * fixed extra whitespace flake8 problems, remaining failure is a copied see all line from another function, the line is over by a period, does not make sense to newline that. * one more whitespace * FIX small pep8 error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarified the role of this function in documentation as requested and added additional see also for more complete context.