[MRG + 1] DOC improve check_memory related docstrings #9649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
circle failure? |
|
Slight grrr, this is because I have enabled CircleCI on my fork and that I haven't got the recent CircleCI fix on master. |
lesteve
force-pushed
the
improve-check-memory-et-al-docstrings
branch
from
02a9e75
to
8a0989e
Compare
|
I have retriggered the build, that should work fine now. |
|
LGTM |
amueller
changed the title
jnothman
pushed a commit
to jnothman/scikit-learn
that referenced
this pull request
Aug 30, 2017
maskani-moh
pushed a commit
to maskani-moh/scikit-learn
that referenced
this pull request
Nov 15, 2017
jwjohnson314
pushed a commit
to jwjohnson314/scikit-learn
that referenced
this pull request
Dec 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #9584 (comment).
Mostly removed joblib.Memory-like in the docstring type info and use this instead:
ping @jnothman @glemaitre